-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format type PVC #6
Conversation
Hey @zedi-pramodh could you please split commit into two? One is changing files in proto, the other including all generated files after running |
storage.proto is the only file that changed. Rest all are generated from "make proto" |
8c6d599
to
df93e6e
Compare
Split the commit as per review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for splitting commits @zedi-pramodh ! I wonder if we should specify that PVC is used for Kubernetes or is it common knowledge
Its a common knowledge, but also the commit message is explicitly saying that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but conflicts in the generated files.
I have no idea on how these conflicts came and how can I resolve those. I just ran "make proto" |
Looks like for every comment line an extra space got added after // |
Some other PR updated an unrelated proto file. This is how I normally resolve these:
|
With kubevirt eve the storage format for volumes will be of type PVC. So add PVC format to storage.proto Signed-off-by: Pramodh Pallapothu <[email protected]>
Signed-off-by: Pramodh Pallapothu <[email protected]>
3b490e4
to
88e66c5
Compare
Updated the commit after rebase to upstream/main. |
With kubevirt eve the storage format for volumes will be of type PVC. So add PVC format to storage.proto
Rest of the files are coming from "make proto"