Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge-Node-Cluster: node, pod, volume, replica, upgrade health. #63

Merged

Conversation

andrewd-zededa
Copy link
Contributor

Edge Node Clusters: nodes, volumes, replicas, upgrades

Node Info: role, age, ip
Pod Info: status, restarts, ip
Volume and Replica Info: rebuild progress, health
Upgrade Status: cluster wide and node components

@andrewd-zededa andrewd-zededa marked this pull request as ready for review August 9, 2024 22:44
@andrewd-zededa
Copy link
Contributor Author

Noticed a bad option in proto/info/edge_node_cluster.proto, fixing that in the next push.

proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
proto/info/edge_node_cluster.proto Outdated Show resolved Hide resolved
@milan-zededa
Copy link
Contributor

Yetus has some opinions on the naiming of enum values...

@andrewd-zededa
Copy link
Contributor Author

@milan-zededa I don't see a 'make yetus' rule like the eve repo has, is there another convenience method to kick it off locally with the rules for this repo?

@andrewd-zededa
Copy link
Contributor Author

Addressed the type concerns for relative -> absolute times now using google.protobuf.Timestamp. I think I'll push another change to rename the 'age' fields to 'creation_timestamp' to match field name in Kubernetes json output.

@andrewd-zededa
Copy link
Contributor Author

Latest commit renames 'age' fields to absolute style 'creation_timestamp'

@andrewd-zededa andrewd-zededa force-pushed the andrewd-kubevirt-upgrade-info branch 2 times, most recently from e487a11 to 28229bb Compare August 19, 2024 22:56
@andrewd-zededa
Copy link
Contributor Author

Latest commits had to pull ErrorInfo out to a separate file to resolve dependency issues created when adding KubeClusterInfo to InfoContent.

@eriknordmark
Copy link
Contributor

Looks like there are still build issues

@andrewd-zededa
Copy link
Contributor Author

Addressed some yetus issues I missed, and separate commit for the generated go, python, svg files.

@andrewd-zededa
Copy link
Contributor Author

Reorganized and moved back ErrorInfo due to the yetus issues. I have a yetus target in my local copy of the makefile which I've been experimenting with using to try to catch these issues before a PR but it seems its not catching enough yet.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewd-zededa
Copy link
Contributor Author

The publishing process of the top level message KubeClusterUpgradeStatus can be simplified if it is allowed to be a top level message type to be published. Only one node will be upgrading/updating at any time so no leader election should be needed to publish KubeClusterUpgradeStatus if the currently updating node is the only node which publishes it. The message would only be sent while the edge-node reports that it is in upgrade-test.

@naiming-zededa What do you think?

@naiming-zededa
Copy link
Contributor

@andrewd-zededa makes sense, since the nodes are upgrade one at a time and it needs to have controller connection at the time, so update by it's own is fine.

@andrewd-zededa
Copy link
Contributor Author

Latest change elevates KubeClusterUpgradeStatus into the InfoContent field of ZInfoMsg.

@andrewd-zededa
Copy link
Contributor Author

I'll fix a mismatch I see between 'upgrade' / 'update' conventions, I'll fix those.

@eriknordmark
Copy link
Contributor

@andrewd-zededa looks like you got a conflict with Pramodh's PR.
Are there some remaining issues causing yetus failures?

@andrewd-zededa
Copy link
Contributor Author

Yeah I'll fix the conflict, looks like I just need to regenerate the built files

@andrewd-zededa
Copy link
Contributor Author

Updated comments on KubePodStatus, rename upgrade->update to match existing baseos update. Rebase on main and rebuilt generated files to resolve conflict.

@andrewd-zededa
Copy link
Contributor Author

Looks like the two info messages KubeClusterInfo and KubeClusterUpdateStatus should probably be renamed to ZInfoKubeClusterInfo and ZInfoKubeClusterUpdateStatus but these types are getting a bit long so I'm open to suggestions to shorten them.

@andrewd-zededa
Copy link
Contributor Author

Another commit pending to append to the ZInfoTypes enum.

Node Info: role, age, ip
Pod Info: status, restarts, ip
Volume and Replica Info: rebuild progress, health
Upgrade Status: cluster wide and node components

Signed-off-by: Andrew Durbin <[email protected]>
Signed-off-by: Andrew Durbin <[email protected]>
@eriknordmark eriknordmark merged commit 7c8ebda into lf-edge:main Aug 29, 2024
3 of 4 checks passed
zedi-pramodh pushed a commit to zedi-pramodh/eve that referenced this pull request Aug 29, 2024
Need to bump eve-api after PRs
lf-edge/eve-api#65
lf-edge/eve-api#63

Signed-off-by: Pramodh Pallapothu <[email protected]>
zedi-pramodh pushed a commit to zedi-pramodh/eve that referenced this pull request Aug 29, 2024
Need to bump eve-api after following PRs
lf-edge/eve-api#63
lf-edge/eve-api#65

Signed-off-by: Pramodh Pallapothu <[email protected]>
OhmSpectator pushed a commit to lf-edge/eve that referenced this pull request Aug 29, 2024
Need to bump eve-api after following PRs
lf-edge/eve-api#63
lf-edge/eve-api#65

Signed-off-by: Pramodh Pallapothu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants