Edge-Node-Cluster: cluster admission additions #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naiming-zededa After some discussion with @xyuria-zededa we felt there were two missing fields here. admission_status will help the controller to show the eventual-consistent state of a node entering/leaving a cluster. cluster_id necessary for a controller to link ZInfoKubeCluster to existing cluster info. If you two have a moment to review I would appreciate it, I don't see an option for me to add you two as reviewers here. |
ZInfoKubeCluster needs a cluster_id which should match the id in config.EdgeNodeCluster.cluster_id Track node entrance into or out of a cluster with KubeNodeInfo.admission_status (NodeAdmission) Signed-off-by: Andrew Durbin <[email protected]>
Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
cluster-status-20240925
branch
from
9aac9ac
to
4be6340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZInfoKubeCluster needs a cluster_id which should match the id in config.EdgeNodeCluster.cluster_id
Track node entrance into or out of a cluster with KubeNodeInfo.admission_status (NodeAdmission)