LPD-37739 move protobuf to share-dependencies and upgrade to 3.25.5 #7478

jeffwu0724 · 2024-09-30T23:47:12Z

Hi Tina,

This is for ticket https://liferay.atlassian.net/browse/LPD-37739.
As talked, I create a shared-dependencies module for protobuf, and then upgrade it to higher version.
Thanks for checking.

liferay-continuous-integration · 2024-09-30T23:47:17Z

CI is automatically triggering the following test suites:

ci:test:sf

jeffwu0724 · 2024-09-30T23:47:45Z

ci:test:sf

jeffwu0724 · 2024-09-30T23:47:54Z

ci:test:relevant

jeffwu0724 · 2024-09-30T23:48:01Z

ci:test:core-functional

jeffwu0724 · 2024-09-30T23:48:37Z

ci:test:acceptance

liferay-continuous-integration · 2024-10-01T00:12:27Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02d74feaa1a4be90f3209096c1c66ca3f659a0b1

Sender Branch:

Branch Name: LPD-37739_upgrade_protobuf_to_3.25.5_new
Branch GIT ID: 3490f819deb1d3039f513b9e1d38c575b825a581

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-10-01T00:13:19Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02d74feaa1a4be90f3209096c1c66ca3f659a0b1

Sender Branch:

Branch Name: LPD-37739_upgrade_protobuf_to_3.25.5_new
Branch GIT ID: 3490f819deb1d3039f513b9e1d38c575b825a581

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-10-01T00:14:09Z

Jenkins Build:test-portal-source-format#6651

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-core-infra#7478

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jeffwu0724 > liferay-core-infra - PR#7478 - 2024-09-30[16:47:26]

Testray Build ID:27522434

Testray Importer:publish-testray-report#24505

liferay-continuous-integration · 2024-10-01T00:14:57Z

Jenkins Build:test-portal-source-format#6593

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-core-infra#7478

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jeffwu0724 > liferay-core-infra - PR#7478 - 2024-09-30[16:47:59]

Testray Build ID:27522436

Testray Importer:publish-testray-report#24561

liferay-continuous-integration · 2024-10-01T00:58:50Z

✔️ ci:test:stable - 28 out of 28 jobs passed

✔️ ci:test:relevant - 34 out of 35 jobs passed in 1 hour 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02d74feaa1a4be90f3209096c1c66ca3f659a0b1

Upstream Comparison:

Branch GIT ID: 613bcc9f840318d1789c3689ae1f300090956ee4
Jenkins Build URL: EE Development Acceptance (master) - 873 - 2024-09-30[12:38:31]

ci:test:stable - 28 out of 28 jobs PASSED

28 Successful Jobs:

ci:test:relevant - 33 out of 35 jobs PASSED

2 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
- js-unit-jdk8/1/0
modules-compile-jdk8
modules-integration-mysql57-jdk8
- modules-integration-mysql57-jdk8/0/0
- modules-integration-mysql57-jdk8/0/1
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
modules-semantic-versioning-jdk8
- modules-semantic-versioning-jdk8/0/0
modules-unit-jdk8
- modules-unit-jdk8/0/0
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
playwright-js-tomcat90-mysql57-jdk8
- playwright-js-tomcat90-mysql57-jdk8/0/0
playwright-js-tomcat90-mysql57-jdk8_stable
- playwright-js-tomcat90-mysql57-jdk8_stable/0/0
semantic-versioning-jdk8
- ~~semantic-versioning-jdk8/0/0~~
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

33 Successful Jobs:

For more details click here.

Failures unique to this pull:

semantic-versioning-jdk8/0/0

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2024-10-01T00:59:45Z

✔️ ci:test:acceptance - 33 out of 33 jobs passed in 1 hour 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02d74feaa1a4be90f3209096c1c66ca3f659a0b1

Upstream Comparison:

Branch GIT ID: 613bcc9f840318d1789c3689ae1f300090956ee4
Jenkins Build URL: EE Development Acceptance (master) - 873 - 2024-09-30[12:38:31]

ci:test:acceptance - 33 out of 33 jobs PASSED

33 Successful Jobs:

test-portal-acceptance-pullrequest(master)
build-iw-jdk8
- build-iw-jdk8/0/0
central-requirements-jdk8
- central-requirements-jdk8/0/0
functional-smoke-tomcat90-mysql57-jdk8_stable
- functional-smoke-tomcat90-mysql57-jdk8_stable/0/0
functional-upgrade-tomcat90-mysql57-jdk8_stable
js-unit-jdk8
- js-unit-jdk8/0/0
- js-unit-jdk8/1/0
modules-compile-jdk8
modules-integration-mysql57-jdk8_stable
- modules-integration-mysql57-jdk8_stable/0/0
- modules-integration-mysql57-jdk8_stable/0/1
modules-unit-jdk8_stable
- modules-unit-jdk8_stable/0/0
playwright-compile-jdk8
- playwright-compile-jdk8/0/0
playwright-js-tomcat90-mysql57-jdk8_stable
- playwright-js-tomcat90-mysql57-jdk8_stable/0/0
rest-builder-jdk8
- rest-builder-jdk8/0/0
service-builder-jdk8
- service-builder-jdk8/0/0
unit-jdk8_stable
- unit-jdk8_stable/0/0
workspaces-compile-jdk8
- workspaces-compile-jdk8/0/0

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2024-10-01T01:02:25Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5129

Jenkins Report:jenkins-report.html

Jenkins Suite:acceptance

Pull Request:liferay-core-infra#7478

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:acceptance - jeffwu0724 > liferay-core-infra - PR#7478 - 2024-09-30[16:48:50]

Testray Build ID:27532075

Testray Importer:publish-testray-report#34147

liferay-continuous-integration · 2024-10-01T01:04:47Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#18078

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-core-infra#7478

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jeffwu0724 > liferay-core-infra - PR#7478 - 2024-09-30[16:48:05]

Testray Build ID:27532077

Testray Importer:publish-testray-report#39156

liferay-continuous-integration · 2024-10-01T01:11:33Z

❌ ci:test:core-functional - 192 out of 233 jobs passed in 1 hour 23 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_5128

Base Branch:

Branch Name: master
Branch GIT ID: 02d74feaa1a4be90f3209096c1c66ca3f659a0b1

Upstream Comparison:

Branch GIT ID: 613bcc9f840318d1789c3689ae1f300090956ee4
Jenkins Build URL: EE Development Acceptance (master) - 873 - 2024-09-30[12:38:31]

ci:test:core-functional - 192 out of 233 jobs PASSED

41 Failed Jobs:

192 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-jdk8/0/4

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

LocalFile.Clustering#CanInvokeMethods - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/0/6

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

LocalFile.Clustering#CanUpdateLogLevelsForAllNodesFromSlave - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/0/10

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

LocalFile.Clustering#NoErrorOnNodeStartupIfCacheManagerNotReady - Poshi Report - Poshi Summary - Poshi Console - Console Output - Liferay Log

functional-tomcat90-mysql57-jdk8/2/4

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

functional-tomcat90-mysql57-jdk8/2/11

Please fix semantic versioning on jeffwu0724/LPD-37739_upgrade_protobuf_to_3.25.5_new

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.security.auth.verifier   MAJOR      2.0.0      2.1.0      3.0.0      VERSION INCREASE REQUIRED
     [exec]   >   interface  com.liferay.portal.kernel.security.auth.verifier.AuthVerifier
     [exec]     -   method     isForceable()
     [exec]       -   return     boolean
     [exec]   +   version    2.0.0
     [exec]   -   version    2.1.0
     [exec] [Baseline Warning] Bundle Version Change Recommended: 152.0.0
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/151.0.0/bab22099c71430308c9bbc164c76c5ddc6cd71a6/com.liferay.portal.kernel-151.0.0.jar

...

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2024-10-01T01:15:52Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5128

Jenkins Report:jenkins-report.html

Jenkins Suite:core-functional

Pull Request:liferay-core-infra#7478

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:core-functional - jeffwu0724 > liferay-core-infra - PR#7478 - 2024-09-30[16:48:10]

Testray Build ID:27533274

Testray Importer:publish-testray-report#34148

jeffwu0724 · 2024-10-01T16:27:55Z

ci:report:27533274

liferay-continuous-integration · 2024-10-01T16:30:04Z

Build completed.

Testray CSV has been generated successfully for testrayBuildID: 27533274.

Job Link: generate-testray-csv

Testray CSV Link: testray-results-27533274.csv

jeffwu0724 · 2024-10-01T16:35:46Z

core-functional:
https://testray.liferay.com/#/project/35392/routines/45357/build/27533274/case-result/27534363/history -- not unique
https://testray.liferay.com/#/project/35392/routines/45357/build/27533274/case-result/27535151/history -- not unique
https://testray.liferay.com/#/project/35392/routines/45357/build/27533274/case-result/27535155/history -- not unique

jeffwu0724 · 2024-10-01T16:37:12Z

Hi @vicnate5 ,
This PR is to upgrade protobuf, and its usages are

./modules/apps/portal-store/portal-store-gcs/build.gradle:     compileInclude group: "com.google.protobuf", name: "protobuf-java", version: "3.21.7" 
./modules/apps/portal-store/portal-store-gcs/build.gradle:     compileInclude group: "com.google.protobuf", name: "protobuf-java-util", version: "3.21.7" 
./modules/apps/site-initializer/site-initializer-testray/site-initializer-testray-dispatch-task-executor/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java", version: "3.21.7" 
./modules/apps/site-initializer/site-initializer-testray/site-initializer-testray-dispatch-task-executor/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java-util", version: "3.21.7" 
./modules/dxp/apps/portal-rules-engine-drools/portal-rules-engine-drools/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java", version: "3.21.7" 
./modules/util/sass-compiler-dart/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java", version: "3.21.7" 
./workspaces/liferay-testray-workspace/modules/testray-rest-impl/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java", version: "3.21.7" 
./workspaces/liferay-testray-workspace/modules/testray-rest-impl/build.gradle: compileInclude group: "com.google.protobuf", name: "protobuf-java-util", version: "3.21.7"

May I ask do you think we should trigger more test here, please?

jeffwu0724 added 5 commits September 30, 2024 12:40

LPD-37739 create a shared-dependencies module for protobuf

a6d9004

LPD-37739 apply usage, changed to use compileOnly for protobuf

748b5a9

LPD-37739 upgrade protobuf-java and protobuf-java-util to 3.25.5

b8eded2

LPD-37739 auto SF

5c60130

LPD-37739 auto generate, by running "ant build-lib-versions"

3490f81

jeffwu0724 changed the title ~~LPD-37739~~ LPD-37739 move protobuf to share-dependencies and upgrade to 3.25.5 Sep 30, 2024

liferay-continuous-integration added ci:test:sf - pending ci:test:core-functional - pending ci:test:relevant - pending ci:test:stable - pending ci:test:acceptance - pending ci:test:sf - success and removed ci:test:sf - pending labels Sep 30, 2024

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - success labels Oct 1, 2024

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 1, 2024

liferay-continuous-integration removed the ci:test:acceptance - pending label Oct 1, 2024

liferay-continuous-integration added the ci:test:acceptance - success label Oct 1, 2024

liferay-continuous-integration added ci:test:core-functional - failure and removed ci:test:core-functional - pending labels Oct 1, 2024

liferay-continuous-integration added the ci:test - pending label Oct 1, 2024

liferay-continuous-integration added ci:test - success and removed ci:test - pending labels Oct 1, 2024

LPD-37739 move protobuf to share-dependencies and upgrade to 3.25.5 #7478

Are you sure you want to change the base?

LPD-37739 move protobuf to share-dependencies and upgrade to 3.25.5 #7478

Conversation

jeffwu0724 commented Sep 30, 2024 • edited Loading

liferay-continuous-integration commented Sep 30, 2024

jeffwu0724 commented Sep 30, 2024

jeffwu0724 commented Sep 30, 2024

jeffwu0724 commented Sep 30, 2024

jeffwu0724 commented Sep 30, 2024

liferay-continuous-integration commented Oct 1, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 1, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 1, 2024

liferay-continuous-integration commented Oct 1, 2024

liferay-continuous-integration commented Oct 1, 2024

✔️ ci:test:stable - 28 out of 28 jobs passed

✔️ ci:test:relevant - 34 out of 35 jobs passed in 1 hour 11 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-continuous-integration commented Oct 1, 2024

✔️ ci:test:acceptance - 33 out of 33 jobs passed in 1 hour 11 minutes

Base Branch:

Upstream Comparison:

For more details click here.

Test bundle downloads:

liferay-continuous-integration commented Oct 1, 2024

liferay-continuous-integration commented Oct 1, 2024

liferay-continuous-integration commented Oct 1, 2024

❌ ci:test:core-functional - 192 out of 233 jobs passed in 1 hour 23 minutes

Base Branch:

Upstream Comparison:

41 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-continuous-integration commented Oct 1, 2024

jeffwu0724 commented Oct 1, 2024

liferay-continuous-integration commented Oct 1, 2024

Build completed.

jeffwu0724 commented Oct 1, 2024

jeffwu0724 commented Oct 1, 2024

jeffwu0724 commented Sep 30, 2024 •

edited

Loading