LPS-174358 | FDS - Add Ignore poshi test + Tab key navigation skips dropdown on filter label #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 11 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-174358 1 Failed Jobs:For more details click here. [exec] Generating types (27 of 31): @liferay/oauth2-provider-web
[exec] Generating types (28 of 31): @liferay/object-dynamic-data-mapping-form-field-type
[exec] Generating types (29 of 31): @liferay/object-web
[exec]
[exec] ***************
[exec] *** WARNING ***
[exec] ***************
[exec]
[exec] Out-of-date TypeScript build artifacts at:
[exec]
[exec] apps/object/object-web/types
[exec]
[exec] Please commit them.
[exec]
[exec] M modules/apps/object/object-web/types/src/main/resources/META-INF/resources/js/components/ObjectAction/useObjectActionForm.d.ts
[exec]
[exec] Generating types (30 of 31): product-navigation-simulation-device
[exec] Generating types (31 of 31): segments-web
[exec] Preflight check failed:
[exec] checkTypeScriptTypeArtifacts() failed: Error: Type generation was successful but 1 project was out of date. Please commit updated versions of the artifacts in the projects listed above.
[exec]
[exec] Prettier checked 3 files
[exec]
[exec] 1 of 3 jobs failed
[exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[exec] error Command failed with exit code 1.
[exec]
[exec] > Task :packageRunCheckFormat FAILED
[exec] Gradle build finished at 2023-03-10 16:25:16.968.
[exec]
[exec]
[exec] FAILURE: Build failed with an exception.
[exec]
[exec] * What went wrong:
[exec] Execution failed for task ':packageRunCheckFormat'.
[exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
[exec]
[exec] * Try:
[exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[exec]
[exec] * Exception is:
[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$3(ExecuteActionsTaskExecuter.java:186)
[exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:268)
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173) |
|
ci:test:relevant |
|
Jenkins Build:test-portal-source-format#5869 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3115 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#3322 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8537 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3115 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - mateusralv > liferay-frontend - PR#3115 - 2023-03-10[08:30:13] Testray Importer:publish-testray-report#20830 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#525 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3115 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - mateusralv > liferay-frontend - PR#3115 - 2023-03-10[10:00:08] Testray Importer:publish-testray-report#778 |
|
ci:test:sf |
liferay-continuous-integration
added
ci:test:sf - pending
and removed
ci:test:sf - failure
labels
kresimir-coko
changed the title
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
❌ ci:test:stable - 25 out of 26 jobs passed❌ ci:test:relevant - 73 out of 77 jobs passed in 2 hours 35 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c832c579510ae04b6bb29aa4447a00f97209627d ci:test:stable - 25 out of 26 jobs PASSED1 Failed Jobs:
25 Successful Jobs:ci:test:relevant - 73 out of 77 jobs PASSED4 Failed Jobs:
73 Successful Jobs:For more details click here.Failures unique to this pull:
Test bundle downloads:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6862 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3115 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - mateusralv > liferay-frontend - PR#3115 - 2023-03-13[14:05:48] Testray Importer:publish-testray-report#14877 |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#131623 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8561 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3115 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - mateusralv > liferay-frontend - PR#3115 - 2023-03-13[17:55:29] Testray Importer:publish-testray-report#20874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add the property for the CI to skip the test according to this #3094 (comment)
Original PR: #3094
cc: @kresimir-coko @manoelcyreno
https://issues.liferay.com/browse/LPS-174358
In order to have the proper focus behaviour it was needed to pass a
ClayButtoncomponent instead of theClayLabelcomponent as atriggerfor theClayDropDown.I have also noticed a lot of SF inconsistencies in the
frontend-data-set-webmodule, for example missing empty lines between sibling elements. Are we disabling our ESLint rules somehow in this module?