Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-194344 Scrape the spritemap and add RequiredMark for required inputs #3635

Closed
wants to merge 2 commits into from
Closed

LPS-194344 Scrape the spritemap and add RequiredMark for required inputs #3635

wants to merge 2 commits into from

Conversation

kresimir-coko
Copy link
Collaborator

Continuation of brianchandotcom#139849
A proper variant of #3622

Reason for a new PR is that a lot of changes happened in the meanwhile (mostly by @thektan), and conflict resolution.

In this PR I am doing the following:

  • passing spritemap from the backend to our Actions component
  • consuming the spritemap in a ClaySelect that offers the scraped icons
  • adjusting the icon preview that updates as the user is changing the icon in the ClaySelect
  • importing and using the RequiredMark component to mark inputs as required

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f81dc316e4f3f1dcfe5e0865f8c92e365e67b9c5

Sender Branch:

Branch Name: LPS-194344
Branch GIT ID: 49c092646223a624b67cdfc31958ca36c8035280

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 30 out of 30 jobs passed

❌ ci:test:relevant - 97 out of 112 jobs passed in 2 hours 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f81dc316e4f3f1dcfe5e0865f8c92e365e67b9c5

Upstream Comparison:

Branch GIT ID: f81dc316e4f3f1dcfe5e0865f8c92e365e67b9c5
Jenkins Build URL: EE Development Acceptance (master) - 4797 - 2023-09-03[00:38:25]

ci:test:stable - 30 out of 30 jobs PASSED
30 Successful Jobs:
    ci:test:relevant - 97 out of 112 jobs PASSED

    15 Failed Jobs:

    97 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      Failures in common with acceptance upstream results at f81dc31:
      3. ...
      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @mateusralv
      Copy link

      Hey @kresimir-coko the failures are not related.

      Testray comparison

      markocikos
      markocikos reviewed Sep 6, 2023
      View reviewed changes
      Copy link
      Collaborator

      @markocikos markocikos left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      @kresimir-coko please see comments inline.

      This will have conflicts with #3639, but that's fine. This one is likely to be the first one merged.

      ...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx Show resolved Hide resolved
      ...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx Outdated Show resolved Hide resolved
      ...et/frontend-data-set-views-web/src/main/resources/META-INF/resources/js/fds_view/Actions.tsx Show resolved Hide resolved
      @kresimir-coko
      Copy link
      Collaborator Author

      I've rebased and force-pushed the changes, nothing significant but it covers all your comments @markocikos I think this should be forwardable, thoughts?

      markocikos
      markocikos approved these changes Sep 6, 2023
      View reviewed changes
      Copy link
      Collaborator

      @markocikos markocikos left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      LGTM! ✨

      @kresimir-coko
      Copy link
      Collaborator Author

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 30 out of 30 jobs passed

      ❌ ci:test:relevant - 97 out of 112 jobs passed in 2 hours 42 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: a9e2c728a149462eba7c34aa31b4ac417bccc57d

      Upstream Comparison:

      Branch GIT ID: a9e2c728a149462eba7c34aa31b4ac417bccc57d
      Jenkins Build URL: EE Development Acceptance (master) - 5 - 2023-09-07[00:39:54]

      ci:test:stable - 30 out of 30 jobs PASSED
      30 Successful Jobs:
        ci:test:relevant - 97 out of 112 jobs PASSED

        15 Failed Jobs:

        97 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          Failures in common with acceptance upstream results at a9e2c72:
          4. ...
          Test bundle downloads:

          @liferay-continuous-integration
          Copy link
          Collaborator

          @markocikos
          Copy link
          Collaborator

          ci:forward

          @liferay-continuous-integration
          Copy link
          Collaborator

          CI is automatically triggering the following test suites:

          •     ci:test:relevant
          •     ci:test:sf
          •     ci:test:stable

          The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

          •     ci:test:relevant
          •     ci:test:sf
          •     ci:test:stable

          @liferay-continuous-integration
          Copy link
          Collaborator

          Skipping previously passed test suites:

          • ci:test:sf
          • ci:test:stable

          @liferay-continuous-integration
          Copy link
          Collaborator

          ✔️ ci:test:stable - 30 out of 30 jobs passed

          ❌ ci:test:relevant - 102 out of 113 jobs passed in 2 hours 39 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: bb2e86dc48c9154cb076f1a44e166c21c8f26df0

          Upstream Comparison:

          Branch GIT ID: a9e2c728a149462eba7c34aa31b4ac417bccc57d
          Jenkins Build URL: EE Development Acceptance (master) - 5 - 2023-09-07[00:39:54]

          ci:test:stable - 30 out of 30 jobs PASSED
          30 Successful Jobs:
            ci:test:relevant - 102 out of 113 jobs PASSED

            11 Failed Jobs:

            102 Successful Jobs:
              For more details click here.

              Failures unique to this pull:

              Failures in common with acceptance upstream results at a9e2c72:
              4. ...
              Test bundle downloads:

              @liferay-continuous-integration
              Copy link
              Collaborator

              @kresimir-coko
              Copy link
              Collaborator Author

              ci:forward:force

              1 similar comment
              @markocikos
              Copy link
              Collaborator

              ci:forward:force

              @liferay-continuous-integration
              Copy link
              Collaborator

              CI is automatically triggering the following test suites:

              •     ci:test:relevant
              •     ci:test:sf
              •     ci:test:stable

              The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

              •     ci:test:relevant
              •     ci:test:sf
                AND If the following test suites pass:
              •     ci:test:stable

              @liferay-continuous-integration
              Copy link
              Collaborator

              Skipping previously completed test suites:

              • ci:test:relevant
              • ci:test:sf
                AND Skipping previously passed test suites:
              • ci:test:stable

              @liferay-continuous-integration
              Copy link
              Collaborator

              CI is automatically triggering the following test suites:

              •     ci:test:relevant
              •     ci:test:sf
              •     ci:test:stable

              The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

              •     ci:test:relevant
              •     ci:test:sf
                AND If the following test suites pass:
              •     ci:test:stable

              @liferay-continuous-integration
              Copy link
              Collaborator

              Skipping previously completed test suites:

              • ci:test:relevant
              • ci:test:sf
                AND Skipping previously passed test suites:
              • ci:test:stable

              @liferay-continuous-integration
              Copy link
              Collaborator

              All required test suite(s) completed.
              Forwarding pull request to brianchandotcom.
              Console

              @liferay-continuous-integration
              Copy link
              Collaborator

              Error has occurred while attempting to forward pull request to brianchandotcom. Retrying in 1 minute...
              See console log for detail:Full Console

              1 similar comment
              @liferay-continuous-integration
              Copy link
              Collaborator

              Error has occurred while attempting to forward pull request to brianchandotcom. Retrying in 1 minute...
              See console log for detail:Full Console

              @liferay-continuous-integration
              Copy link
              Collaborator

              Pull request will not be forwarded to brianchandotcom.

              @markocikos markocikos mentioned this pull request Sep 8, 2023
              Closed
              @markocikos
              Copy link
              Collaborator

              manual forward: brianchandotcom#140463

              @markocikos markocikos closed this Sep 8, 2023
              @kresimir-coko kresimir-coko deleted the LPS-194344 branch April 19, 2024 05:57
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @markocikos markocikos markocikos approved these changes

              @dsanz dsanz Awaiting requested review from dsanz

              Assignees
              No one assigned
              Labels
              ci:test:relevant - failure ci:test:sf - success ci:test:stable - success ready-for-qa Ready for QA review
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              4 participants
              @kresimir-coko @liferay-continuous-integration @mateusralv @markocikos