Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/css): Modal Height Full should overflow when content is t… #5646

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Jul 24, 2023

…oo tall

fixes #5643

@matuzalemsteles
Copy link
Member

matuzalemsteles commented Jul 25, 2023

I'm not sure if it makes sense to add this to the modal-body if we already have the inline-scroller that can be configured in the <Modal.Body scrollable />.

Maybe just remove the max-height from inline-scroller?

@pat270
Copy link
Member Author

pat270 commented Jul 25, 2023

@matuzalemsteles Edu and Dani clarified what they are expecting. I think they want the modal to grow and stop when it reaches window height. I'll update this pr and take the scrollable attribute into account. It should work like the gif below.

modal-grow

@matuzalemsteles
Copy link
Member

@pat270 I'm moving forward with this, maybe inline-scroller isn't something valid anymore since this will be the default now.

@matuzalemsteles matuzalemsteles merged commit 105ec07 into liferay:master Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@clayui/modal Enable modal-dialog-scrollable
2 participants