Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@clayui/navigation-bar): Adds fluidSize prop to customize container-fluid width #5657

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Aug 3, 2023

https://liferay.atlassian.net/browse/LPS-192418

@matuzalemsteles I added the prop fluidSize to ClayNavigationBar. We currently allow ClayLayout.ContainerFluid to omit outputting the class container-fluid-max-{size} if the size=false. Should we add a new fluidSize, something like fluid or fluid-layout, in ClayLayout.Container to do that instead?

@matuzalemsteles
Copy link
Member

Should we add a new fluidSize, something like fluid or fluid-layout, in ClayLayout.Container to do that instead?

I'm not sure, ClayLayout.ContainerFluid is just a wrapper on top of ClayLayout.Container with a simple abstraction so I don't think it would be necessary.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants