Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clayui.com): LPD-33885 clarify difference betweek defaultItems a… #5861

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Aug 16, 2024

…nd items in Dynamic Tables

https://liferay.atlassian.net/browse/LPD-33885

I wasn't sure if I was understanding the difference between defaultItems and items correctly. Lmk if there's wording I need to change.

@matuzalemsteles
Copy link
Member

Hey @pat270 This is related to our controlled and uncontrolled state pattern, you can read more about it here. https://clayui.com/blog/2022/05/02/api-consistency-improvements-for-controlled-and-uncontrolled-components.html.

I think that instead of putting a warning we should actually create a section that summarizes a little of the blog to clarify this point further and link to the blog.

@pat270
Copy link
Member Author

pat270 commented Aug 16, 2024

@matuzalemsteles I'll update and resend, thanks!

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit 1cc56f1 into liferay:master Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants