Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/form): LPD-36696 DualListBox adds children and don't disable left right buttons if no items are selected #5874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Sep 23, 2024

https://liferay.atlassian.net/browse/LPD-36696

I added children to the component so we can pass in things like an error message. I also removed disabling the move buttons if length is 0.

duallistbox-new

…ble left right buttons if no items are selected
…isable left / right arrows if it exceeds max items
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that instead of delegating the implementation of the error to the developer we can add this internally in the component, especially if it is a default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants