Merge pull request #213 from fortunatomaldonado/LPD-34946

LPD-34946 Check if values are empty and delete styles when not used
liferay · Aug 29, 2024 · 88be248 · 88be248
2 parents 6dd0fb9 + 1c0304c
commit 88be248
Show file tree

Hide file tree

Showing 23 changed files with 173 additions and 157 deletions.
diff --git a/ckeditor/ckeditor.js b/ckeditor/ckeditor.js
diff --git a/ckeditor/skins/kama/editor.css b/ckeditor/skins/kama/editor.css
diff --git a/ckeditor/skins/kama/editor_ie.css b/ckeditor/skins/kama/editor_ie.css
diff --git a/ckeditor/skins/kama/editor_ie7.css b/ckeditor/skins/kama/editor_ie7.css
diff --git a/ckeditor/skins/kama/editor_ie8.css b/ckeditor/skins/kama/editor_ie8.css
diff --git a/ckeditor/skins/kama/editor_iequirks.css b/ckeditor/skins/kama/editor_iequirks.css
diff --git a/ckeditor/skins/moono-lexicon/editor.css b/ckeditor/skins/moono-lexicon/editor.css
diff --git a/ckeditor/skins/moono-lexicon/editor_gecko.css b/ckeditor/skins/moono-lexicon/editor_gecko.css
diff --git a/ckeditor/skins/moono-lexicon/editor_ie.css b/ckeditor/skins/moono-lexicon/editor_ie.css
diff --git a/ckeditor/skins/moono-lexicon/editor_ie8.css b/ckeditor/skins/moono-lexicon/editor_ie8.css
diff --git a/ckeditor/skins/moono-lexicon/editor_iequirks.css b/ckeditor/skins/moono-lexicon/editor_iequirks.css
diff --git a/ckeditor/skins/moono-lisa/editor.css b/ckeditor/skins/moono-lisa/editor.css
diff --git a/ckeditor/skins/moono-lisa/editor_gecko.css b/ckeditor/skins/moono-lisa/editor_gecko.css
diff --git a/ckeditor/skins/moono-lisa/editor_ie.css b/ckeditor/skins/moono-lisa/editor_ie.css
diff --git a/ckeditor/skins/moono-lisa/editor_ie8.css b/ckeditor/skins/moono-lisa/editor_ie8.css
diff --git a/ckeditor/skins/moono-lisa/editor_iequirks.css b/ckeditor/skins/moono-lisa/editor_iequirks.css
diff --git a/ckeditor/skins/moono/editor.css b/ckeditor/skins/moono/editor.css
diff --git a/ckeditor/skins/moono/editor_gecko.css b/ckeditor/skins/moono/editor_gecko.css
diff --git a/ckeditor/skins/moono/editor_ie.css b/ckeditor/skins/moono/editor_ie.css
diff --git a/ckeditor/skins/moono/editor_ie7.css b/ckeditor/skins/moono/editor_ie7.css
diff --git a/ckeditor/skins/moono/editor_ie8.css b/ckeditor/skins/moono/editor_ie8.css
diff --git a/ckeditor/skins/moono/editor_iequirks.css b/ckeditor/skins/moono/editor_iequirks.css
diff --git a/plugins/imagespacingbox/plugin.js b/plugins/imagespacingbox/plugin.js
@@ -57,18 +57,26 @@
 
 											var hspace = widget.data.hspace
 												? widget.data.hspace
-												: 0;
+												: '';
 
 											var imageElement =
 												widget.parts.image;
 
-											if (imageElement) {
+											if (imageElement && hspace !== '') {
 												imageElement.setStyles({
 													'margin-left':
 														hspace + 'px',
 													'margin-right':
 														hspace + 'px',
 												});
+											} else {
+												imageElement.removeStyle(
+													'margin-left'
+												);
+
+												imageElement.removeStyle(
+													'margin-right'
+												);
 											}
 										},
 										id: 'hspace',
@@ -127,17 +135,25 @@
 
 											var vspace = widget.data.vspace
 												? widget.data.vspace
-												: 0;
+												: '';
 
 											var imageElement =
 												widget.parts.image;
 
-											if (imageElement) {
+											if (imageElement && vspace !== '') {
 												imageElement.setStyles({
 													'margin-bottom':
 														vspace + 'px',
 													'margin-top': vspace + 'px',
 												});
+											} else {
+												imageElement.removeStyle(
+													'margin-bottom'
+												);
+
+												imageElement.removeStyle(
+													'margin-top'
+												);
 											}
 										},
 										id: 'vspace',