Simple.installer #118
Draft
Simple.installer #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamerson
reviewed
Apr 28, 2023
| @@ -192,7 +52,7 @@ We have a new `Getting Started` guide [available here.](https://github.com/lifer | |||
|
|
|||
| * linux/mac: | |||
| ``` | |||
| rm -rf ~/.lcect* | |||
| rm -rf ~/.liferay/cli* | |||
There was a problem hiding this comment.
should we use ~/.liferay/cx/cli and ~/.liferay/cx/sources?
There was a problem hiding this comment.
I see down below we are using ~/.liferay/cx which I think is a good name.
| @@ -19,6 +21,8 @@ var mkcertCmd = &cobra.Command{ | |||
| Short: "Uses mkcert package to make locally-trusted development certificates.", | |||
| Args: cobra.NoArgs, | |||
| Run: func(cmd *cobra.Command, args []string) { | |||
| os.Setenv("TRUST_STORES", "nss") | |||
There was a problem hiding this comment.
does this "add" to the defaults? or do we still have to add system,java somewhere else?
There was a problem hiding this comment.
this branch is just testing things on Fedora, but yeah. it's "setting" the stores. We can discuss how to choose which stores to use by the user or via config.
…cli' according to go)
rotty3000
force-pushed
the
simple.installer
branch
from
a16bbbd
to
36d35a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.