DOCKER-249 : added environment variable for ignoring fragment #148
Conversation
|
|
There was a problem hiding this comment.
@chinmay-abhyankar, can you please check my comments and resent to my fork of liferay-docker?
Thanks in advance
| @@ -36,6 +36,7 @@ ENV LIFERAY_CONTAINER_KILL_ON_FAILURE=0 | |||
| ENV LIFERAY_CONTAINER_STARTUP_LOCK_ENABLED=false | |||
| ENV LIFERAY_CONTAINER_STARTUP_LOCK_FILE=/opt/liferay/data/liferay-startup-lock | |||
| ENV LIFERAY_CONTAINER_STATUS_ACTIVE_MODULES= | |||
| ENV LIFERAY_CONTAINER_STATUS_IGNORE_ACTIVE_MODULES= | |||
There was a problem hiding this comment.
@chinmay-abhyankar, can you please include this new variable considering the alphabetic order?
Thanks
| # if not set the ignore module, then ignore fragment by default | ||
| lecho "LIFERAY_CONTAINER_STATUS_IGNORE_ACTIVE_MODULES not set, setting its value to ignore fragment" |
There was a problem hiding this comment.
@chinmay-abhyankar, usually, we don't add comments in the code, therefore can you please remove these 2 lines?
| @@ -110,9 +117,9 @@ function main { | |||
| ) | telnet 127.0.0.1 11311 2> /dev/null | |||
| ) | |||
|
|
|||
| local active_count=$(echo "${telnet_content}" | grep -E "${LIFERAY_CONTAINER_STATUS_ACTIVE_MODULES}" | grep -c ACTIVE) | |||
| local active_count=$(echo "${telnet_content}" | grep -v "${LIFERAY_CONTAINER_STATUS_IGNORE_ACTIVE_MODULES}" | grep -E "${LIFERAY_CONTAINER_STATUS_ACTIVE_MODULES}" | grep -c ACTIVE) | |||
There was a problem hiding this comment.
@chinmay-abhyankar, considering that a fragment never transitions to the status Active, please see https://liferay.slack.com/archives/C07GFPNS1AT/p1725532590516359, and it remains in the status Resolved, does it make sense to set by default the value fragment in the variable LIFERAY_CONTAINER_STATUS_IGNORE_ACTIVE_MODULES?
There was a problem hiding this comment.
Generally developers uses fragment in symbolic name of OSGI modules which are use to fragment OOTB modules. So to sent default is to ignore checking of all modules which have word fragment, even if the envionment variable is not set
There was a problem hiding this comment.
I see, @chinmay-abhyankar. Thanks for your clarification! 🙂
Since it seems to be a decision on the developer's side, maybe we should use the content of the variable LIFERAY_CONTAINER_STATUS_IGNORE_ACTIVE_MODULES only if it's set, does it make sense to you?
@natocesarrego adding changes for ignoring fragments