LPD-16638 Expando throws NoSuchColumnException #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oSuchColumnExpection on portal instead of returning null. Need try-catch to deal with this. See ref: https://liferay.atlassian.net/browse/LPD-12631 liferay/liferay-portal@23da8740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngriffin7a Hi Neil,
This is Julius from Core. Recently there was a Liferay Faces functional test that failed see here: https://liferay.atlassian.net/browse/LPD-16638
After investigation, we think there are two things that are causing it:
ExpandoColumnLocalServiceUtil getColumn method impl now throws NoSuchColumnException (it showed up in the functional test) See ref: https://liferay.atlassian.net/browse/LPD-12631, liferay/liferay-portal@23da8740 ----> this PR just catch the exception so that's like the old behavior
log4j1.2 is removed from portal. We need to remove log4j1.2 dependency completely. This part I tried to see what I could do but ultimately could not since I'm not very familiar with all the liferay-faces repos. But I see that you have a ticket here for it almost done: https://liferay.atlassian.net/browse/FACES-3698
Could you please help us take lead and finish removing log4j1.2?
This issue is a release blocker and need to take care soon.
https://liferay.atlassian.net/browse/LPD-16638
Thank you!