fix(alloy-ui): AUI-3222 Avoid calling selectionChange on invaild dates #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markocikos
approved these changes
Apr 12, 2024
|
Thank you @markocikos for reviewing this! Do we know who can merge this? Thank you for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/AUI-3222
https://liferay.atlassian.net/browse/LPD-22812
This is to fix errors in the console when erasing the hour or minutes of input time. By preventing firing
selectionChangewhen the date is invalid, we are able to keep the same behavior without having errors in the log.If we try to fix this in input_time/page.jsp the time will revert to
--:--:-which will be tedious for users having to reenter the time again.Screencast from 04-10-2024 11:12:46 AM.webm