wip(eslint-plugin): add new blank-line-declaration-usage rule and tests for it

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/doctor.js

@@ -86,6 +86,7 @@ function assertTasksSupported(version, tasks) {
 			default:
 				{
 					const message = getSupportedTasks(task)[version] || '';
+
 					if (message !== true) {
 						log(
 							colors.yellow(

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/prompts/__tests__/extend_prompt.test.js

@@ -438,6 +438,7 @@ it('_promptThemeSource should prompt correct workflow', () => {
 	prototype._promptThemeSource();
 
 	const args = inquirer.prompt.getCall(0).args;
+
 	const questions = args[0];
 
 	const extendType = questions[0];

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/prompts/__tests__/prompt_util.test.js

@@ -66,6 +66,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		expect(item.name).toBe(name);
@@ -78,6 +79,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		if (number === 1) {
@@ -93,6 +95,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		expect(!item.checked).toBe(true);
@@ -106,6 +109,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		if (number === 1) {

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/prompts/extend_prompt.js

@@ -71,6 +71,7 @@ class ExtendPrompt {
 		const baseTheme = this.themeConfig.baseTheme;
 		const module = answers.module;
 		const modulePackages = answers.modules;
+
 		const pkg = modulePackages[module];
 
 		if (!module) {

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/theme_finder.js

@@ -114,9 +114,11 @@ function getLiferayThemeModuleFromURL(url) {
 		// Just in case package name doesn't match URL basename, read it.
 
 		const {dependencies} = JSON.parse(fs.readFileSync('package.json'));
+
 		const themeName = Object.keys(dependencies)[0];
 
 		const json = path.join('node_modules', themeName, 'package.json');
+
 		config = JSON.parse(fs.readFileSync(json));
 	});
 
@@ -183,6 +185,7 @@ module.exports = {
  */
 function withScratchDirectory(cb) {
 	const template = path.join(os.tmpdir(), 'theme-finder-');
+
 	const directory = fs.mkdtempSync(template);
 
 	const cwd = process.cwd();

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/upgrade/6.2/upgrade.js

@@ -281,6 +281,7 @@ module.exports = function (options) {
 			.pipe(
 				plugins.filter((file) => {
 					const extname = path.extname(file.path).slice(1);
+
 					const basename = path.basename(file.path, `.${extname}`);
 
 					if (promptResults[basename][extname]) {

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/util.js

@@ -18,6 +18,7 @@ const lfrThemeConfig = require('./liferay_theme_config');
 const argv = minimist(process.argv.slice(2));
 
 const pkg = lfrThemeConfig.getConfig(true);
+
 const themeConfig = pkg.liferayTheme;
 
 const CUSTOM_DEP_PATH_ENV_VARIABLE_MAP = {

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/tasks/__tests__/build.test.js

@@ -147,6 +147,7 @@ describe('using lib_sass', () => {
 
 	function _assertFixAtDirectives(cb) {
 		const cssPath = path.join(buildPath, 'css');
+
 		const mainCssPath = path.join(cssPath, 'main.css');
 
 		expect(fs.existsSync(cssPath)).toBe(true);
@@ -195,6 +196,7 @@ describe('using lib_sass', () => {
 		expect(fs.existsSync(templatesPath)).toBe(true);
 
 		const customCSSFileName = '_custom.scss';
+
 		const customCSSPath = path.join(cssPath, customCSSFileName);
 
 		const fileContent = testUtil.stripNewlines(
@@ -288,6 +290,7 @@ describe('using lib_sass', () => {
 		expect(fs.existsSync(velocityPath)).toBe(true);
 
 		const customCSSFileName = '_custom.scss';
+
 		const customCSSPath = path.join(buildPath, 'css', customCSSFileName);
 
 		expect(fs.readFileSync(customCSSPath).toString()).toMatch(

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/tasks/__tests__/status.test.js

@@ -16,6 +16,7 @@ beforeEach(() => {
 		namespace: 'status_task',
 		registerTasks: true,
 	});
+
 	runSequence = config.runSequence;
 });
 

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/tasks/deploy.js

@@ -12,6 +12,7 @@ const DEPLOYMENT_STRATEGIES = themeUtil.DEPLOYMENT_STRATEGIES;
 
 function registerTasks(options) {
 	const {argv, gulp, pathDist} = options;
+
 	const {storage} = gulp;
 
 	const runSequence = require('run-sequence').use(gulp);

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/tasks/watch.js

@@ -185,8 +185,11 @@ module.exports = function (options) {
 
 	gulp.task('watch:reload', (cb) => {
 		const changedFile = storage.get('changedFile');
+
 		const srcPath = path.relative(process.cwd(), changedFile.path);
+
 		const dstPath = srcPath.replace(/^src\//, '');
+
 		const urlPath = `${resourcePrefix}/${distName}/${dstPath}`;
 
 		livereload.changed({
@@ -276,8 +279,10 @@ module.exports = function (options) {
 			const requestUrl = url.parse(req.url);
 
 			const match = themePattern.exec(requestUrl.pathname);
+
 			if (match) {
 				const filepath = path.resolve('build', match[3]);
+
 				const ext = path.extname(filepath);
 
 				isReadable(filepath).then((exists) => {
@@ -307,9 +312,11 @@ module.exports = function (options) {
 				`Watch mode is now active at: ${url}`,
 				`Proxying: ${proxyUrl}`,
 			];
+
 			const width = messages.reduce((max, line) => {
 				return Math.max(line.length, max);
 			}, 0);
+
 			const ruler = '-'.repeat(width);
 
 			// eslint-disable-next-line no-console

maintenance/projects/js-themes-toolkit-v9-x/packages/generator-liferay-theme/generators/layout/standalone-layout.js

@@ -30,7 +30,9 @@ module.exports = class extends Generator {
 		const cp = new Copier(this);
 
 		const {layoutId, liferayVersion} = this.answers;
+
 		const layoutName = snakeCase(layoutId);
+
 		const templateFilename = `${layoutName}.ftl`;
 		const thumbnailFilename = `${layoutName}.png`;
 
@@ -71,6 +73,7 @@ module.exports = class extends Generator {
 
 	_getDevDependencies() {
 		const {liferayVersion} = this.answers;
+
 		const devDependencies = devDependenciesMap[liferayVersion].default;
 
 		return JSON.stringify(devDependencies, null, 2)

maintenance/projects/js-themes-toolkit-v9-x/packages/generator-liferay-theme/generators/layout/theme-layout.js

@@ -25,7 +25,9 @@ module.exports = class extends Generator {
 		const cp = new Copier(this);
 
 		const {layoutId, liferayVersion} = this.answers;
+
 		const layoutName = snakeCase(layoutId);
+
 		const templateFilename = `${layoutName}.ftl`;
 		const thumbnailFilename = `${layoutName}.png`;
 

maintenance/projects/js-themes-toolkit-v9-x/packages/generator-liferay-theme/lib/Copier.js

@@ -51,6 +51,7 @@ module.exports = class Copier {
 	 */
 	copyDir(src, {context = {}} = {}) {
 		const gen = this._generator;
+
 		const files = fs.readdirSync(gen.templatePath(src));
 
 		files.forEach((file) => {

maintenance/projects/js-themes-toolkit-v9-x/packages/generator-liferay-theme/lib/Project.js

@@ -15,6 +15,7 @@ class Project {
 
 	get type() {
 		const {fs} = this._generator;
+
 		const pkgJson = fs.readJSON('package.json');
 
 		if (pkgJson === undefined) {

maintenance/projects/js-themes-toolkit-v9-x/packages/generator-liferay-theme/lib/generation/theme-based.js

@@ -28,6 +28,7 @@ const pipeline = promisify(stream.pipeline);
 
 async function writing(generator, themeName) {
 	const project = new Project(generator);
+
 	const {liferayVersion} = project;
 
 	print(

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/index.js

@@ -42,6 +42,7 @@ module.exports.registerTasks = function (options) {
 
 function register(options) {
 	const gulp = (options.gulp = plugins.help(options.gulp));
+
 	const store = gulp.storage;
 
 	store.set('changedFile');

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/__tests__/util.test.js

@@ -61,6 +61,7 @@ describe('resolveDependency()', () => {
 		const resolved = util.resolveDependency(
 			'liferay-frontend-theme-styled'
 		);
+
 		expect(resolved).toContain(process.cwd());
 	});
 });

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/prompts/__tests__/extend_prompt.test.js

@@ -436,6 +436,7 @@ it('_promptThemeSource should prompt correct workflow', () => {
 	prototype._promptThemeSource();
 
 	const args = inquirer.prompt.getCall(0).args;
+
 	const questions = args[0];
 
 	const extendType = questions[0];

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/prompts/__tests__/prompt_util.test.js

@@ -66,6 +66,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		expect(item.name).toBe(name);
@@ -78,6 +79,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		if (number === 1) {
@@ -93,6 +95,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		expect(!item.checked).toBe(true);
@@ -106,6 +109,7 @@ it('getModuleChoices should get module choices that are appropriate for extend t
 
 	_.forEach(choices, (item, index) => {
 		const number = index + 1;
+
 		const name = 'themelet-' + number;
 
 		if (number === 1) {

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/prompts/extend_prompt.js

@@ -69,6 +69,7 @@ class ExtendPrompt {
 		const baseTheme = this.themeConfig.baseTheme;
 		const module = answers.module;
 		const modulePackages = answers.modules;
+
 		const pkg = modulePackages[module];
 
 		if (!module) {

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/prompts/url_package_prompt.js

@@ -82,6 +82,7 @@ class URLPackagePrompt {
 		if (this.themelet && answers.module) {
 			Object.keys(answers.module).forEach((k) => {
 				const moduleName = this.config.selectedModules[k];
+
 				answers.module[moduleName] = answers.module[k];
 				delete answers.module[k];
 			});

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/r2/liferay-r2/css-parse.js

@@ -26,10 +26,12 @@ module.exports = function (css, options) {
 
 	function updatePosition(str) {
 		var lines = str.match(/\n/g);
+
 		if (lines) {
 			lineno += lines.length;
 		}
 		var i = str.lastIndexOf('\n');
+
 		column = ~i ? str.length - i : column + str.length;
 	}
 
@@ -80,6 +82,7 @@ module.exports = function (css, options) {
 
 	function error(msg, start) {
 		var err = new Error(`${filename} (${lineno}:${column}) ${msg}`);
+
 		err.position = new Position(start);
 		err.filename = filename;
 		err.description = msg;
@@ -142,10 +145,12 @@ module.exports = function (css, options) {
 
 	function match(re) {
 		var m = re.exec(css);
+
 		if (!m) {
 			return;
 		}
 		var str = m[0];
+
 		updatePosition(str);
 		css = css.slice(str.length);
 
@@ -211,6 +216,7 @@ module.exports = function (css, options) {
 
 	function selector() {
 		var m = match(/^([^{]+)/);
+
 		if (!m) {
 			return;
 		}
@@ -232,6 +238,7 @@ module.exports = function (css, options) {
 		// prop
 
 		var prop = match(/^(\*?[-#/*\w]+(\[[0-9a-z_-]+\])?)\s*/);
+
 		if (!prop) {
 			return;
 		}
@@ -246,6 +253,7 @@ module.exports = function (css, options) {
 		// val
 
 		var val = match(/^((?:'(?:\\'|.)*?'|"(?:\\"|.)*?"|\([^)]*?\)|[^};])+)/);
+
 		if (!val) {
 			return error('property missing value');
 		}
@@ -462,6 +470,7 @@ module.exports = function (css, options) {
 	function atpage() {
 		var pos = position();
 		var m = match(/^@page */);
+
 		if (!m) {
 			return;
 		}
@@ -499,6 +508,7 @@ module.exports = function (css, options) {
 	function atdocument() {
 		var pos = position();
 		var m = match(/^@([-\w]+)?document *([^{]+)/);
+
 		if (!m) {
 			return;
 		}
@@ -585,10 +595,12 @@ module.exports = function (css, options) {
 	function _atrule(name) {
 		var pos = position();
 		var m = match(new RegExp('^@' + name + ' *([^;\\n]+);'));
+
 		if (!m) {
 			return;
 		}
 		var ret = {type: name};
+
 		ret[name] = trim(m[1]);
 
 		return pos(ret);