Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for MAVEN-14 for review and merge #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution for MAVEN-14 for review and merge #2

wants to merge 1 commit into from

Conversation

kameshsampath
Copy link

The following are the files updated, added, removed as part of the MAVEN-14 related fixes

Files Added

  1. liferay-maven-support/plugins/liferay-maven-plugin-components - this new project takes care of the code generation for Search container, this is componentized to allow reuse of code generation and defining new code builder for other Liferay Portal feature.The components defined in this module/project are injectable to the Mojo using via the Plexus Container
  2. liferay-maven-support/plugins/liferay-maven-plugin/src/main/java/com/liferay/maven/plugins/xml/SearchContainerModelParser.java - the Parser class that is used to parse the Mojo model for SearchContainer Mojo
  3. liferay-maven-plugin/src/main/java/com/liferay/maven/plugins/SearchContainerMojo.java - the Maven plugin that will take care of generating the Liferay Search Container code with jsps
  4. liferay-maven-plugin/src/test - the unit test folder

Files Updated

  1. liferay-maven-support/plugins/pom.xml - added the entry for the module liferay-maven-plugin-components
  2. liferay-maven-support/plugins/liferay-maven-plugin/pom.xml - added the dependencies related to maven plugin automation and unit tests and added reporting section to generate plugin documentation and other reports
  3. .gitignore - to add pattern .~ that will ignore the linux swap files

Other comments

The unit tests are very basic, just started to make the mechanics work, need to be more robust like automated checking instead of unlike whats done manually now. Will try to update them in next iterations. The reporting plugins are in place to enablke the plugin documentation in future for all the maven plugins defined

How to integrate with liferay maven projects

  1. Create a liferay maven portlet project
  2. Create a search-containers.xml file, an example is available in the liferay-maven-plugin/src/test_ folder
  3. Run the maven command mvn liferay:build-search-container
  4. A set of Java classes wil be generated in the src folder and set of jsps will be generated in the src/main/webapp folder

paul--shemansky pushed a commit to paul--shemansky/liferay-maven-support that referenced this pull request May 1, 2014
paul--shemansky pushed a commit to paul--shemansky/liferay-maven-support that referenced this pull request May 1, 2014
paul--shemansky pushed a commit to paul--shemansky/liferay-maven-support that referenced this pull request May 1, 2014
paul--shemansky pushed a commit to paul--shemansky/liferay-maven-support that referenced this pull request May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant