Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lpd 35068 4 #6082

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Lpd 35068 4 #6082

wants to merge 15 commits into from

Commits on Sep 30, 2024

  1. LPD-35068 Add themeId to style-book-service

    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    34bf4a5 View commit details
    Browse the repository at this point in the history

  2. LPD-35068 buildService 

    # breaking

## What modules/apps/style-book/style-book-service/service.xml

Added themeId and themeName to modules/apps/style-book/style-book-service/service.xml

## Why

To allow the user to choose a token definition for a new Style Book to be based on. These changes were added and the bundle version was updated by buildService in style-book-api/bnd.bnd.

----
    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ad474a9 View commit details
    Browse the repository at this point in the history

  3. LPD-35068 Update LocalServiceImpl with themeId

    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    30bbac2 View commit details
    Browse the repository at this point in the history

  4. LPD-35068 Update tests

    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0d905f4 View commit details
    Browse the repository at this point in the history

  5. LPD-35068 formatSource

    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    29ce300 View commit details
    Browse the repository at this point in the history

  6. LPD-35068 Update StyleBook Upgrade Process with themeId

    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d334c2e View commit details
    Browse the repository at this point in the history

  7. LPD-35068 baseline 

    # breaking

## What modules/apps/style-book/style-book-service/src/main/java/com/liferay/style/book/internal/upgrade/registry/StyleBookServiceUpgradeStepRegistrator.java

Added themeId and themeName to StyleBookServiceUgpradeStepRegistrator.java

## Why

CI failed a previous commit because the added themeId and themeName columns could not be found after an upgrade was performed, so these columns were added to the database here. I ran foratSource and baseline in modules/apps/style-book and style-book-service/bnd.bnd was updated.

----
    @SelenaAungst @thiago-buarqque
    SelenaAungst authored and thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a362f9d View commit details
    Browse the repository at this point in the history

  8. LPD-35068 themeId will soon be required to create a style book, so le… 

    …t's already add it in the 'add' methods
    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    85f38f1 View commit details
    Browse the repository at this point in the history

  9. LPD-35068 buildService

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    175d820 View commit details
    Browse the repository at this point in the history

  10. LPD-35068 Update usages

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c38f0c2 View commit details
    Browse the repository at this point in the history

  11. LPD-35068 we must specify the size on the portlet-model-hints.xml fil… 

    …e. Otherwise new databases will differ from upgraded ones
    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    db0cd9a View commit details
    Browse the repository at this point in the history

  12. LPD-35068 buildService

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9f645e6 View commit details
    Browse the repository at this point in the history

  13. LPD-35068 serviceContext must come last

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1965733 View commit details
    Browse the repository at this point in the history

  14. LPD-35068 buildService

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3843257 View commit details
    Browse the repository at this point in the history

  15. LPD-35068 update usages and use RandomTestUtil for the themeId value

    @thiago-buarqque
    thiago-buarqque committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7873ad3 View commit details
    Browse the repository at this point in the history