New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add users filtering while exporting #404

Open

mayank190801 wants to merge 1 commit into llaske:dev from mayank190801:updatefix/313

+31 −6

Contributor

mayank190801 commented May 1, 2023

Fixes issue #313

I have taken motivation from last pull request on this issue.

Now users can be exported on the basis of name, role and classrooms.
'All' option is added, using which all users can be exported.
Instead of using parameters part of the URL, I have grouped them into query.
Filtering logic is simplified.
Misleading variable names are removed.
Indentation is fixed.
Used Array.filter for better logic representation.

This is an updated pull request for the requested changes.

@llaske @NikhilM98 Please review it and lemme know if any changes are required.


          Add users filtering while exporting

93684a4

mayank190801 mentioned this pull request

Add users filtering while exporting #362

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet