Finished winning effect on memorize #1614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llaske
reviewed
Apr 25, 2024
There was a problem hiding this comment.
This file is a common Sugar library it's not suppose to be updated.
llaske
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
My name is Zad Khan and I am working on an assignment to contribute to an open-source project. I communicated my intention of fixing the winning effect on the 'Memorize' activity in the forums and am pleased to update it is finished.
Existing issue: #1018
Please see the changes I have made - notably including new functions within 'memorize-app.js' to include isGameOver, celebrateWin and resetGame. I also created a new directory for sounds which has 'applause.mp3'.
I hope this is of use. I had a great time working with the sugarizer team and hope this helps more young students learn.