Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldb-dap] Correct auto-completion based on ReplMode and escape char #110784

Merged
merged 5 commits into from
Oct 3, 2024
Merged

[lldb-dap] Correct auto-completion based on ReplMode and escape char #110784

merged 5 commits into from
Oct 3, 2024

Commits on Oct 2, 2024

  1. [lldb-dap] Correct auto-completion based on ReplMode and escape char 

    This commit improves the auto-completion in the Debug Console provided
by VS-Code.

So far, we were always suggesting completions for both LLDB commands and
for variables / expressions, even if the heuristic already determined
how the given string will be executed, e.g., because the user explicitly
typed the escape prefix. Furthermore, auto-completion after the escape
character was broken, since the offsets were not adjusted correctly.
With this commit we now correctly take this into account.

Even with this commit, auto-completion does not always work reliably:

* VS Code only requests auto-completion after typing the first
  alphabetic character, but not after punctuation characters. This means
  that no completions are provided after typing "`"
* LLDB does not provide autocompletions if a string is an exact match.
  This means if a user types `l` (which is a valid command), LLDB will
  not provide "language" and "log" as potential completions. Even worse,
  VS Code caches the completion and does client-side filtering. Hence,
  even after typing `la`, no auto-completion for "language" is shown in
  the UI.

Those issues might be fixed in follow-up commits. Also with those known
issues, the experience is already much better with this commit.

Furthermore, I updated the README since I noticed that it was slightly
inaccurate.
    @vogelsgesang
    vogelsgesang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    41694e6 View commit details
    Browse the repository at this point in the history

  2. Code formatting

    @vogelsgesang
    vogelsgesang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    633b347 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @vogelsgesang
    vogelsgesang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    db19aed View commit details
    Browse the repository at this point in the history

  4. Fix test comment

    @vogelsgesang
    vogelsgesang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4129d65 View commit details
    Browse the repository at this point in the history

  5. Code style...

    @vogelsgesang
    vogelsgesang committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    cc0985d View commit details
    Browse the repository at this point in the history