[Xtensa] Implement branch relaxation. #110959
Open
+757
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Oct 3, 2024
| case Xtensa::BGEI: | ||
| case Xtensa::BGEUI: | ||
| return MI.getOperand(2).getMBB(); | ||
|
|
Comment on lines
+335
to
+339
| bool XtensaInstrInfo::analyzeBranch(MachineBasicBlock &MBB, | ||
| MachineBasicBlock *&TBB, | ||
| MachineBasicBlock *&FBB, | ||
| SmallVectorImpl<MachineOperand> &Cond, | ||
| bool AllowModify = false) const { |
There was a problem hiding this comment.
This family of functions should be implemented independently of branch relaxation. They're more used for branch folding
Comment on lines
+488
to
+491
| // FIXME: A virtual register must be used initially, as the register | ||
| // scavenger won't work with empty blocks (SIInstrInfo::insertIndirectBranch | ||
| // uses the same workaround). | ||
| Register ScratchReg = MRI.createVirtualRegister(&Xtensa::ARRegClass); |
There was a problem hiding this comment.
I think this got fixed actually. The workaround might still be there though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.