Skip to content
This repository has been archived by the owner on Sep 10, 2023. It is now read-only.

Fix for add token base on id - w.r.t. original file #766

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prajyotsji
Copy link

No description provided.

@korun
Copy link
Contributor

korun commented Mar 19, 2015

Why do you open these PR's? For what?

@prajyotsji
Copy link
Author

@korun Hi, I'm using the js lib in one of my projects. I was facing issue with token 'C++' this works well with the forked js. But add token(append) had issue.

@korun
Copy link
Contributor

korun commented Mar 19, 2015

So, can you provide some descriptions for your PR's?
Otherwise, this PR looks quite useless, since you just removed the tokenValue option support!

@prajyotsji
Copy link
Author

Yes, thank you for your time.

The reason to include the forked js lib was because there was no 'C++' or special characters returned in original file.

for add_token function Line : 655 - existing_data - returned me object with id and name - Object {id: "3", name: "Name"}
Above is the reason to remove tokenValue and replace it with id. Thus the functionality worked.

This was just a quick fix from my side to make the js in project working and it works fine currently as per my requirement.

If you may please suggest some changes if it is not correctly done, or is there any other way I can use this plugin in my project. As the changes were made only because of 'C++'. It would be very helpful. :)

@korun
Copy link
Contributor

korun commented Mar 19, 2015

I can't reproduce your bug.
I made this jsfiddle, and, as you can see, C++ token addition with add_token function works fine.
Provide your own jsfiddle example if I done some mistake.

@loopj loopj force-pushed the master branch 2 times, most recently from fd2316b to 8a8390e Compare August 3, 2023 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants