Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: name column in the dashboad being squashed in some aspect ratios #4193

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

jaybhanushali3166
Copy link
Contributor

@jaybhanushali3166 jaybhanushali3166 commented Dec 8, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3293 name column in the dashboard being squashed in some aspect ratios @louislam

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@jaybhanushali3166 jaybhanushali3166 changed the title fix issue: #3293, media queries for dashboard table name column Fix: name column in the dashboad being squashed in some aspect ratios Dec 8, 2023
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label Dec 8, 2023
Copy link
Collaborator

@chakflying chakflying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breakpoints are a bit weird, but tested seems to work okay.

@jaybhanushali3166
Copy link
Contributor Author

Breakpoints are a bit weird, but tested seems to work okay.

I have updated the breakpoints , thanks!

@chakflying chakflying added the area:ui/ux Interface and User Experience issues label Jan 23, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the style fix! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 3e88772 into louislam:master Aug 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown area:ui/ux Interface and User Experience issues pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name column in the dashboad being squashed in some aspect ratios
3 participants