Remove quoting from tag keys and values #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official `latest` Docker image for InfluxDB is now a 2.x image. That image now supports initial provisioning via environment variables like the 1.x image does. This makes the following changes: - Explicitly use a v1.x image (latest is 1.8) for the v1 tests - Use the DockerHub image for v2 tests - Use the new image's built-in provisioning support to simplify the Makefile - Use a hard-coded token to avoid having to inject it everywhere dynamically in the tests - Revert back to using `/api/v2/delete` for cleaning up after tests. It is now supported again, and the v1 compatibility endpoint wasn't working the same way with the latest version. - Remove the `.token` file from `.gitignore`; we no longer generate this file.
We found that our tag keys and values had spurious double-quotes in them when trying to query the data from InfluxDB. According to the [line protocol documentation](https://docs.influxdata.com/influxdb/v2.0/reference/syntax/line-protocol/#quotes), > Line protocol accepts double and single quotes in measurement names, tag keys, tag values, and field keys, but interprets them as part of the name, key, or value. Double-quotes are required for field values, so that behavior is preserved here. Co-authored-by: Randy Coulman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is built on top of #22 in order to be able to run the tests. Please merge that PR first. Only the last commit is part of this PR.
We found that our tag keys and values had spurious double-quotes in them when trying to query the data from InfluxDB.
According to the line protocol documentation,
Double-quotes are required for field values, so that behavior is preserved here.