Add support for Pandoc Markdown #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
requested changes
Sep 29, 2020
| pandoc = function(format) | ||
| return function(text) | ||
| local out_filename = os.tmpname() | ||
| local in_file = io.popen("pandoc -f markdown -t html -o " .. out_filename .. " -", "w") |
There was a problem hiding this comment.
Overall this PR looks good and I'd love to see it merged, but this bit of coding seems counter intuitive to me. You're writing to something called "in_file" and reading from "out_file" — but it's really tricky to realize whose perspective on in and out is being used here. I suggest using names that better represent what they are ... tmpfile, stdin or fifo or some such?
Otherwise I'll give this a test drive and make sure it works, then merge.
There was a problem hiding this comment.
Maybe markdown_file and html_file (based on the contents)?
|
Because I merged cmark support from another PR, this will require a minor bit of conflict resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another part of the solution to #162, along with #326. This PR adds support for Pandoc, which is a very robust and featureful Markdown processor written in Haskell. Since there's not really any way to directly integrate the library we just assume it's on
PATHand call it as an external program.I've tried to minimize the number of temporary files created, but apparently Lua has no
popen2equivalent so I think this is the best we can do (without additional dependencies or extensions).I've confirmed that this works to at least a basic level with Pandoc's built-in syntax highlighting if you use it in combination with #326 and set
pretty="none".