Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound splat arguments, fixes GH-54 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

amireh
Copy link
Collaborator

@amireh amireh commented Jan 14, 2017

Unfortunately, this is a breaking change and requires a major release.
The patch makes it so that we no longer reject more than 999 repetitions
for a splat argument, and that by default we allow for unlimited
arguments (maxcount=0 or nil) instead of 1.

amireh and others added 2 commits December 18, 2023 18:19
BREAKING CHANGE: The default maxcount value for SPLAT arguments is now
unlimited. The previous default was 1. That was unexpected for many
folks and arguably wrong, but fixing it is a major breaking change and
consumers will need to adjust, hence the major version bump. The old
behaviour can be achieved by setting the maxcount to 1 again:

    cli:splat('MY_SPLAT', 'Description', nil, 1)

Additionally a limit of 999 has been resolved so unlimited arguments can
be accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants