fix for stat(2) path traversal using fstat #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moteus
reviewed
May 18, 2020
| return(3); | ||
| } | ||
| #endif | ||
| if (st(fd, &info)) { | ||
| lua_pushnil(L); |
There was a problem hiding this comment.
I think you should also close file inside if statement
|
@jaromil Feel free to simplify the internals if it aids with the bugfix and preserves portability! |
|
Thanks for your feedbacks, knowing your interest now I'll rework the PR into something more presentable and passing tests. |
hishamhm
force-pushed
the
master
branch
2 times, most recently
from
9cd10fe
to
f77f248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Here is my fix to retrieve correct file information on POSX systems when along the path traversal a directory has no executable flag.
From
stat(2)manpage:At the moment this is an incomplete fix: it breaks usage of
lstat(2)on POSIX systems, due to change of the function signature passed to_file_info_().Kindly provide feedback on how to proceed. IMHO the usage of a function pointer passed as argument of file_info is a design burden: a simple flag can be used.
ciao
p.s. for the impatient, a quick non-breaking fix is applied in the lfs version shipped in my software.