Add support for SchedulerName for Flink pods #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anandswaminathan
commented
Apr 29, 2024
•
anandswaminathan
commented
- Provides the ability to add Scheduler name from config.
anandswaminathan
requested review from
premsantosh and
maghamravi
as code owners
|
LGTM @anandswaminathan ! a qq, is there a specific use case this new config parameter is aimed for, apart from capturing it. |
maghamravi
previously approved these changes
Apr 29, 2024
maghamravi
approved these changes
Apr 29, 2024
nji302
approved these changes
Apr 29, 2024
|
Since the config is not aware of environment (staging vs prod), are we waiting until the new maxAllocated scheduler is also available on data1-prd before merging in this PR? |
|
@nji302 The config is at the operator level. Operator is separate for each K8s cluster - configured in Lyft private repo |
tomwans
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.