Keep midpoint on the line #1141
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the average of Mercator coordinates of the two endpoints, the middle points were drawn off from the line. By project/unproject the Mercator latitudes to and from screen space, the screen location for midpoints would be fixed onto the line.
Keep midpoint on the line
As simple_select sometimes renders lines as `MultiLineString` geometry, sort ranking should handle this type or midpoint click would not work.
As simple_select sometimes renders lines as `MultiLineString` geometry, sort ranking should handle this type or midpoint clicking would fail.
|
Hi @zhangchn, Thanks for the PR! Could you please review the failing tests in the CI? |
|
IMHO, my patch changed the way midpoints were located. Test cases which assume the midpoints were located the old way failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the average of Mercator coordinates of the two endpoints, the middle points were drawn off from the line.
By project/unproject the Mercator latitudes to and from screen space, the screen location for midpoints would be fixed onto the line.