Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lower baselines for the heatmaps in WebGL2 Firefox #12734

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stepankuzmin
Copy link
Contributor

Revert lower baselines for the heatmaps in WebGL2 Firefox from #12701

Launch Checklist

  • briefly describe the changes in this PR
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label May 31, 2023
@stepankuzmin stepankuzmin requested a review from mourner May 31, 2023 13:16
@@ -123,9 +123,10 @@ function bindTextureToFramebuffer(context: Context, painter: Painter, texture: ?
// Use the higher precision half-float texture where available (producing much smoother looking heatmaps);
// Otherwise, fall back to a low precision texture
/* $FlowFixMe[prop-missing] WebGL2 */
const type = context.extRenderToTextureHalfFloat ? (context.isWebGL2 ? gl.HALF_FLOAT : context.extTextureHalfFloat.HALF_FLOAT_OES) : gl.UNSIGNED_BYTE;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heatmaps work with this fix now with WebGL2, but I'm unsure about removing the gl.getExtension('EXT_color_buffer_half_float') check here. /cc @astojilj

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this might break some Android GPUs that don't support EXT_color_buffer_half_float. So we're still blocked by Firefox not supporting EXT_color_buffer_half_float in WebGL 2.0 contexts.

@stepankuzmin stepankuzmin marked this pull request as ready for review May 31, 2023 13:19
@stepankuzmin stepankuzmin requested a review from a team as a code owner May 31, 2023 13:19
@stepankuzmin stepankuzmin marked this pull request as draft August 21, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant