Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyze.yml to accept executor as input. #2116

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

billyjbryant
Copy link
Member

Description

Updates the CodeQL Workflow to accept the executor as input, allowing provision for self-hosted runners when re-using the workflow.

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. Put tests in correct Test Plan (Unit, Integration, All)
    • If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main first and then port to v10.[version] release branch.

PRs must be submitted under the terms of our Contributor License Agreement CLA.

### Description

Updates the CodeQL Workflow to accept the executor as input, allowing provision for self-hosted runners when re-using the workflow.
@billyjbryant billyjbryant requested a review from a team as a code owner February 9, 2024 00:13
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aleksproger aleksproger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changes to internal repo after testing here

@billyjbryant
Copy link
Member Author

Move changes to internal repo after testing here

@aleksproger : I'm not certain what you are asking to be changed? PR https://github.com/mapbox/mapbox-maps-ios-internal/pull/2022 has already been opened for internal repo changes that are required; however, this PR is a pre-req of that PR.

@billyjbryant billyjbryant merged commit 5e8503c into main Feb 9, 2024
7 checks passed
@billyjbryant billyjbryant deleted the billyjbryant/executor branch February 9, 2024 20:31
@OdNairy
Copy link
Contributor

OdNairy commented Feb 14, 2024

I have to force-remove the commit as it broke our infrastructure.
Please, do not merge PRs into maps-ios repository – it has to go through the internal infrastructure instead.

OdNairy added a commit that referenced this pull request Feb 14, 2024
* Update analyze.yml to accept executor as input. (#2116)

Updates the CodeQL Workflow to accept the executor as input, allowing provision for self-hosted runners when re-using the workflow.

* Create dependabot.yml

Enable Dependabot version updates

---------

Co-authored-by: Billy Bryant <[email protected]>
Co-authored-by: Thibaud Lopez Schneider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants