Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make destination annotation methods public #4253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jill-cardamon
Copy link
Contributor

This PR makes NavigationMapView.addDestinationAnnotation and NavigationMapView.removeDestinationAnnotation public, adds a callback based on style loading, and changes the way identifiers are handled.

@kried kried marked this pull request as draft January 18, 2023 10:05
@kried kried removed the request for review from MaximAlien January 18, 2023 10:05
@kried kried assigned kried and unassigned jill-cardamon Jan 18, 2023
@kried kried force-pushed the jill/NAVIOS-678-present-final-annotation-navigationMapView branch 3 times, most recently from bc90da8 to 372223b Compare January 18, 2023 15:47
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #4253 (790cbad) into main (05396b8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4253      +/-   ##
==========================================
+ Coverage   61.04%   61.06%   +0.02%     
==========================================
  Files         189      189              
  Lines       21179    21181       +2     
==========================================
+ Hits        12928    12935       +7     
+ Misses       8251     8246       -5     
Impacted Files Coverage Δ
Sources/MapboxNavigation/NavigationMapView.swift 64.00% <100.00%> (+0.35%) ⬆️

@kried kried marked this pull request as ready for review January 18, 2023 16:33
@kried kried force-pushed the jill/NAVIOS-678-present-final-annotation-navigationMapView branch from 372223b to 9e29e97 Compare March 8, 2023 16:42
@kried kried force-pushed the jill/NAVIOS-678-present-final-annotation-navigationMapView branch from 9e29e97 to 790cbad Compare March 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants