Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarPlay alternative routes display #4489

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

Udumft
Copy link
Contributor

@Udumft Udumft commented Jun 23, 2023

Description

Added loading continuous alternatives on NavigationViewController startup, which previously resulted in showing only the main route when NavigationService was created beforehand. Fixed displaying route steps when starting navigation from CarPlay by correctly calling the connection handler

…tives on NavigationViewController startup; fixed displaying route steps when starting navigation from CarPlay
@Udumft Udumft self-assigned this Jun 23, 2023
@Udumft Udumft marked this pull request as ready for review June 23, 2023 14:45
@Udumft Udumft requested a review from a team as a code owner June 23, 2023 14:45
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #4489 (f3ddff7) into main (aa5c63c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4489   +/-   ##
=======================================
  Coverage   58.31%   58.32%           
=======================================
  Files         189      189           
  Lines       21190    21192    +2     
=======================================
+ Hits        12358    12360    +2     
  Misses       8832     8832           
Impacted Files Coverage Δ
...es/MapboxNavigation/NavigationViewController.swift 51.11% <100.00%> (+0.10%) ⬆️

@Udumft Udumft merged commit b4f5284 into main Jun 27, 2023
4 checks passed
@Udumft Udumft deleted the vk/NAVIOS-1265-carplay-alternatives branch June 27, 2023 07:35
Copy link

@FETTYMACC FETTYMACC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry guys I'm not the best at this app anything I'm doing wrong let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants