Skip to content

Commit

Permalink
Remove unused variables in mapillary/opensfm/opensfm/src/geometry/pose.h
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D53779585

fbshipit-source-id: d651d6b4cf4dbc777f924f936e9325005c80d2ba
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 15, 2024
1 parent 2281fd4 commit 072abf0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion opensfm/src/geometry/pose.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class Pose {
virtual ~Pose() = default;

Pose(const Vec3d& R, const Vec3d& t = Vec3d::Zero()) {
Mat4d T_cw = Mat4d::Identity();
SetFromWorldToCamera(R, t);
}
Pose(const Mat3d& R, const Vec3d& t = Vec3d::Zero()) {
Expand Down

0 comments on commit 072abf0

Please sign in to comment.