Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour on PPC64EL #761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

piotrmaslanka
Copy link

@piotrmaslanka piotrmaslanka commented May 28, 2021

After much combat we (Dronehub) managed to get opensfm to work on ppc64el.

Double, while calculating abs(det) is promoted to int on ppc64el, so that previously the condition that has been changed always held true.

I've fixed it as follows

Double, while calculating abs(det) is promoted to int on ppc64el, so that the modified condition always held.

Since abs from cmath also returns wrong result, I've fixed it as follows.
@facebook-github-bot
Copy link
Contributor

Hi @piotrmaslanka!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants