-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the cognitive_data package to manage the data #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cognitive_data package deps
…n-id Require participant and session id i UserConfig
improve: Instantiate InMemoryDB in manager
Improve how the type of session is identified
refactor(forward): Use participantID in runDigitSpanForward refactor(forward): Add param participantID runDigitSpanForward refactor(forward): Pass participantID runDigitSpanForward
refactor(forward): Pass sessionID config runDigitSpanForward refactor(forward): Require sessionID in runDigitSpanForward refactor(forward): Pass sessionID to runDigitSpanForward
refactor(backwards): Pass participantID to config refactor(backwards): Require participantID to run refactor(backwards): Pass participantID to runDigitSpanBackwards
refactor(backwards): Pass sessionID to config refactor(backwards): Require sessionID run refactor(backwards): Pass sessionID runDigitSpanBackwards
…pant-id Use sessionID and participantID in DSF DSB
refactor: Implement startTime as field in manager improve: Define startTime field in manager refactor: Fix setting startTime refactor: Make startTime private Can be squashed into previous commits
startTime will be set directly on the field.
refactor: Implement setter for startTime refactor: Use new startTime setter
improve: Implement endTime as field in manager improve: Implement endTime as field in manager improve: Implement endTime as field in manager improve: Define endTime field in manager refactor: Fix setting endTime refactor: Make endTime private maint: Remove empty lines lint: Remove empty line
endTime will be set directly in the field.
refactor: Implement setter for endTime refactor: Use new endTime setter
improve: Define data model to return to user fix: Fix DigitSpanTaskData constructor
improve: Impl DigitSpanTaskData.toString() fix: Fix DigitSpanTaskData.toString() represen
test: Incomplete work - add test test: Fix DataManager.collectMetadata() test Can be squashed into previous commits test: Add asserts to DataManager.collectMetadata() test: Update imports in data_manager_test test: Cleanup DataManager.collectMetadata() test Can be squashed into previous commits doc: Add comment to explain test code Can be squashed into previous commits
Can be squashed into previous commits
improve: Impl DataManager.collect_metadata() maint: Update data_manager.dart imports
doc: Add docstring to DataManager.collectMetadata() doc: Update docstring DataManager.collectMetadata()
Collect metadata about the session and devie
doc: Update DataManager.export docstring doc: Update DataManager.export docstring Can be squashed into previous commits
test: Add test Datamanager.export() test: Fix DataManager tests Needed to update setup and teardown to better dispose of getx controllers test: Fix DataManager.export test Needed to define startTime test: Simplify DataManager.export test Removes code that was not needed and uses the participantID defined in main.
Update method that exports data to based on the new way that data is managed
Originally DigitSpanTasksData
Remove old code and their references
fix: Remove late from DigitSpanTaskData fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes many major changes. The most notable ones are:
Additionally, data management was simplified considerable because DigitSpanTasks now uses the cognitive_package to manage the data.
Type of Change
Checklist