Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the cognitive_data package to manage the data #104

Merged
merged 79 commits into from
Mar 2, 2024

Conversation

mario-bermonti
Copy link
Owner

Description

This pull request includes many major changes. The most notable ones are:

  • the data returned by DigitSpanTasks contains the trials (practice and experimental), metadata about the session, meetadata about the device on which the data was collected.

Additionally, data management was simplified considerable because DigitSpanTasks now uses the cognitive_package to manage the data.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🐞 Bug fix (non-breaking change that fixes an issue)
  • 🔧 Maintenance (non-breaking change that improves code)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
  • 🔐 Improvements to the CI workflow

Checklist

mario-bermonti and others added 30 commits February 23, 2024 10:09
…n-id

Require participant and session id i UserConfig
improve: Instantiate InMemoryDB in manager
Improve how the type of session is identified
refactor(forward): Use participantID in runDigitSpanForward

refactor(forward): Add param participantID runDigitSpanForward

refactor(forward): Pass participantID runDigitSpanForward
refactor(forward): Pass sessionID config runDigitSpanForward

refactor(forward): Require sessionID in runDigitSpanForward

refactor(forward): Pass sessionID to runDigitSpanForward
refactor(backwards): Pass participantID to config

refactor(backwards): Require participantID to run

refactor(backwards): Pass participantID to runDigitSpanBackwards
refactor(backwards): Pass sessionID to config

refactor(backwards): Require sessionID run

refactor(backwards): Pass sessionID runDigitSpanBackwards
…pant-id

Use sessionID and participantID in DSF DSB
refactor: Implement startTime as field in manager

improve: Define startTime field in manager

refactor: Fix setting startTime

refactor: Make startTime private

Can be squashed into previous commits
startTime will be set directly on the field.
refactor: Implement setter for startTime

refactor: Use new startTime setter
improve: Implement endTime as field in manager

improve: Implement endTime as field in manager

improve: Implement endTime as field in manager

improve: Define endTime field in manager

refactor: Fix setting endTime

refactor: Make endTime private

maint: Remove empty lines

lint: Remove empty line
endTime will be set directly in the field.
refactor: Implement setter for endTime

refactor: Use new endTime setter
mario-bermonti and others added 27 commits February 28, 2024 10:02
improve: Define data model to return to user

fix: Fix DigitSpanTaskData constructor
improve: Impl DigitSpanTaskData.toString()

fix: Fix DigitSpanTaskData.toString() represen
test: Incomplete work - add test

test: Fix DataManager.collectMetadata() test

Can be squashed into previous commits

test: Add asserts to DataManager.collectMetadata()

test: Update imports in data_manager_test

test: Cleanup DataManager.collectMetadata() test

Can be squashed into previous commits

doc: Add comment to explain test code

Can be squashed into previous commits
Can be squashed into previous commits
improve: Impl DataManager.collect_metadata()

maint: Update data_manager.dart imports
doc: Add docstring to DataManager.collectMetadata()

doc: Update docstring DataManager.collectMetadata()
Collect metadata about the session and devie
doc: Update DataManager.export docstring

doc: Update DataManager.export docstring

Can be squashed into previous commits
test: Add test Datamanager.export()

test: Fix DataManager tests

Needed to update setup and teardown to better dispose of
getx controllers

test: Fix DataManager.export test

Needed to define startTime

test: Simplify DataManager.export test

Removes code that was not needed and uses the participantID defined in
main.
Update method that exports data to based on the new way that data is managed
Originally DigitSpanTasksData
fix: Remove late from DigitSpanTaskData fields
@mario-bermonti mario-bermonti merged commit 8ee921b into master Mar 2, 2024
2 checks passed
@mario-bermonti mario-bermonti deleted the mario-bermonti/issue89 branch March 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant