Make startTime and endTime fields in the data manager #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Implement startTime as field in manager improve: Define startTime field in manager refactor: Fix setting startTime refactor: Make startTime private Can be squashed into previous commits
startTime will be set directly on the field.
refactor: Implement setter for startTime refactor: Use new startTime setter
improve: Implement endTime as field in manager improve: Implement endTime as field in manager improve: Implement endTime as field in manager improve: Define endTime field in manager refactor: Fix setting endTime refactor: Make endTime private maint: Remove empty lines lint: Remove empty line
endTime will be set directly in the field.
refactor: Implement setter for endTime refactor: Use new endTime setter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These fields are defined by the user using the setter methods provided.
Because practice and experimental phases are considered part of the same session, the startTime is set with the practice phase start time and the endTime is set with the experimental phase end time.
Related Issue
Type of Change
Checklist