Mirror more data per repo and allow arbitrary user mirroring #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brycey92
commented
Mar 5, 2024
| visibility="${1:-}" | ||
| log "Create migration user with name: ${github_user}" | ||
| local password=$(tr -dc 'A-Za-z0-9!@#$%^&*()_+\-=[]{}\|;:,.<>/`~' < /dev/urandom | head -c 64) | ||
| if ! $CURL -X POST $GITEA_URL/api/v1/admin/users "${header_options[@]}" --data '{"username": "'"${github_user}"'", "visibility": "'"${visibility}"'", "email": "'"${github_user}@example.com"'", "password": "'"${password}"'", "must_change_password": true}' > ${jsonoutput}/result.txt 2>${jsonoutput}/stderr.txt; then |
There was a problem hiding this comment.
Despite the Gitea API documentation saying the password field is not required, it is required, and Gitea will return a 400 Bad Request error without it.
|
Thank you for your PR, @Brycey92!
This would break existing deployments that do not use an auth token (e.g., if one wants to mirror a public organization), right? I like that!
Well done. |
|
One additional thought came to my mind: it would be nice if the mirroring of git LFS data and wikis would be configurable individually. Maybe not all users want to mirror a whole bunch of large(r) data files or the wiki information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable LFS and wiki mirroring, and use auth token for all repo mirrors
Allow --mode user to fetch repos of arbitrary --user value
Improve error handling and error clarity
I made a number of design decisions while writing this that you'll have to decide whether you like or not. Where possible, I attempted to avoid breaking existing command syntax.