Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download.sh: add --no-config to all wget calls #465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varenc
Copy link

@varenc varenc commented Jul 20, 2023

This addresses an issue where wget would use the user's ~/.wgetrc file, which could cause problems if the user had configured wget to use certain user-agents. In general, ignoring the user's config seems like a good idea.

Issue I ran into specifically is here: #418 (comment)

This addresses an issue where wget would use the user's ~/.wgetrc
file, which could cause problems if the user had configured wget to
use certain user-agents.  In general, ignoring the user's config
seems like a good idea.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2023
@msaroufim msaroufim added the download-install Download and installation issues label Sep 1, 2023
@MadnessIRL
Copy link

Great find! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. download-install Download and installation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants