Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue Splitting Feature #2173

Merged
merged 96 commits into from
Aug 16, 2024
Merged

Queue Splitting Feature #2173

merged 96 commits into from
Aug 16, 2024

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Jan 14, 2024 •
edited
Loading

@t4lz t4lz mentioned this pull request Jan 14, 2024
Closed
54 tasks
Razz4780
Razz4780 reviewed Jan 24, 2024
View reviewed changes
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
@t4lz t4lz force-pushed the sqs branch 3 times, most recently from f367850 to 828e66e Compare April 4, 2024 12:11
@t4lz t4lz force-pushed the sqs branch 2 times, most recently from befb24b to b25cffa Compare May 6, 2024 21:45
@t4lz
Splitter CRD
73e6789 
Add new features enum and field for operator

The old enum cannot be extended as it would break old clients.
So we define a new extensible enum and a new field for it.
We make all of those fields private so that users of that struct
only access them via a getter that handles objects deserialized
from either old or new versions.

use copy target when splitting
Razz4780
Razz4780 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing ^^

@t4lz
Copy link
Member Author

t4lz commented Aug 15, 2024

What changed besides the requested changes:

  • Added #[schemars(skip)] #[serde(skip_serializing)] to unknown (#[serde(other)]) CRD enum variants, so that they are not part of the schema, but only deserialized when a peer has a newer version and sends a new, unknown variant.
  • Changed QueueConsumer to a struct because that's now a better representation after having added a container.

Razz4780
Razz4780 requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small ser/de changes

mirrord/operator/src/crd.rs Show resolved Hide resolved
mirrord/operator/src/crd.rs Outdated Show resolved Hide resolved
@t4lz @Razz4780
CR: out of place serde tag
7b7f4dd 
Co-authored-by: Michał Smolarek <[email protected]>
@t4lz t4lz enabled auto-merge August 16, 2024 11:56
@t4lz t4lz added this pull request to the merge queue Aug 16, 2024
Merged via the queue into metalbear-co:main with commit d97df8d Aug 16, 2024
17 checks passed
@t4lz t4lz deleted the sqs branch August 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviramha aviramha aviramha left review comments

@Razz4780 Razz4780 Razz4780 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t4lz @Razz4780 @aviramha