Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for HTTP upgrades in intproxy (HTTP filter) #2226

Merged
merged 12 commits into from
Feb 12, 2024
Merged

Allow for HTTP upgrades in intproxy (HTTP filter) #2226

merged 12 commits into from
Feb 12, 2024

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented Feb 9, 2024

Closes #2224

  • RawInterceptor and HttpInterceptor merged into one type, that freely switches between being a TCP proxy and an HTTP gateway
  • Added version requirement to mirrord-protocol
  • Added a unit test for HTTP upgrade

meowjesty
meowjesty requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking into incoming/interceptor.rs, but I found some minor stuff to comment on.

mirrord/intproxy/src/proxies/incoming.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming/http.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming/interceptor.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming/interceptor.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming/interceptor.rs Show resolved Hide resolved
meowjesty
meowjesty requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just docs missing requests I guess.

mirrord/intproxy/src/proxies/incoming/interceptor.rs Outdated Show resolved Hide resolved
mirrord/intproxy/src/proxies/incoming/interceptor.rs Show resolved Hide resolved
meowjesty
meowjesty approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Razz4780 Razz4780 added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@Razz4780 Razz4780 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into metalbear-co:main with commit 02dde90 Feb 12, 2024
16 checks passed
@Razz4780 Razz4780 deleted the 2224 branch February 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowjesty meowjesty meowjesty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust intproxy to allow stealing upgraded connections
2 participants
@Razz4780 @meowjesty