Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same output rules for both meshed and not meshed networks #2264

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

DmitryDodzin
Copy link
Member

closes #2255

According to -m owner --gid-owner {gid} -p tcp -j RETURN rule the agent traffic should be unaffected and -o lo should limit to localhost requests only.

Looks working =]

@DmitryDodzin DmitryDodzin marked this pull request as ready for review February 29, 2024 10:05
@DmitryDodzin
Copy link
Member Author

Since we have StandardRedirect on non meshed connection the changes in #1070 are irrelevant so this PR is OK

@DmitryDodzin
Copy link
Member Author

Checked with sidecars and everything worked as expected

Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

mirrord/agent/src/steal/ip_tables/mesh.rs Outdated Show resolved Hide resolved
changelog.d/2255.fixed.md Outdated Show resolved Hide resolved
@aviramha aviramha enabled auto-merge March 7, 2024 13:22
@aviramha aviramha added this pull request to the merge queue Mar 7, 2024
Merged via the queue into metalbear-co:main with commit b2b57f8 Mar 7, 2024
16 checks passed
@DmitryDodzin DmitryDodzin deleted the issue/2255/iptabes branch March 7, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steal + istio + port forward doesn't work
2 participants