Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra path separator in mkdir_p #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bbonf
Copy link

@bbonf bbonf commented May 10, 2024

Closes #404

@dinosaure
Copy link
Member

@MisterDA can you confirm that it's the right fix? Thanks.

@MisterDA
Copy link
Collaborator

@bbonf I can't reproduce the error. How did you encounter it? Could you add a failing test case perhaps?

@bbonf
Copy link
Author

bbonf commented Jun 11, 2024

I'm not sure how to approach adding a test case for this, but here's how I reproduce it:

  1. Installed ocaml on cygwin (windows 10 build 19045)
  2. Created a new switch with ocaml-system.4.14.2
  3. opam install dune alcotest
  4. dune init project foo (in /tmp but I don't think it matters)
  5. Added (libraries alcotest) to test/dune
  6. Pasted this into test/test_foo.ml:
open Alcotest

let test () =
  (check @@ int) "just a test"
    0
    1

let () =
  run "Bar" [
    "test", [
      test_case "something" `Quick test
    ]
  ]
  1. Run dune test

@MisterDA
Copy link
Collaborator

Installed ocaml on cygwin (windows 10 build 19045)

Do you mean that you're using the Cygwin port of OCaml (or the OCaml package from the Cygwin package archive)?
Or that you're using a Cygwin shell (and have the MinGW-w64 or MSVC ports of OCaml)?

@bbonf
Copy link
Author

bbonf commented Jun 11, 2024

Installed the OCaml package from the Cygwin package archive.

(I think I tried and failed to use the mingw port but that's another story)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra path separator prepended in mkdir_p
3 participants