Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: Add sequential accessors & clean dispatcher #2090

Merged
merged 5 commits into from
Sep 23, 2022
Merged

irmin-pack: Add sequential accessors & clean dispatcher #2090

merged 5 commits into from
Sep 23, 2022

Conversation

clecat
Copy link
Contributor

@clecat clecat commented Sep 21, 2022

This PR adds:

  • 2 accessors that uses physical offsets instead of the virtual offsets
  • A generator for sequences of accessors that iterates trough all physical offsets of a pack file.
    It also removes:
  • The root filed of Dispatcher.t, as it is never used.

@clecat clecat added the no-changelog-needed No changelog is needed here label Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2090 (f66d223) into main (368f671) will decrease coverage by 0.14%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   64.75%   64.60%   -0.15%     
==========================================
  Files         132      132              
  Lines       15658    15696      +38     
==========================================
+ Hits        10139    10141       +2     
- Misses       5519     5555      +36     
Impacted Files Coverage Δ
src/irmin-pack/unix/gc.ml 40.54% <0.00%> (ø)
src/irmin-pack/unix/dispatcher.ml 51.18% <2.56%> (-21.86%) ⬇️
src/irmin-pack/unix/ext.ml 61.94% <100.00%> (ø)
src/irmin-pack/unix/snapshot.ml 77.34% <100.00%> (ø)
src/irmin-fs/irmin_fs.ml 81.21% <0.00%> (-1.22%) ⬇️
src/irmin-fs/unix/irmin_fs_unix.ml 68.38% <0.00%> (+0.64%) ⬆️
src/irmin/watch.ml 80.98% <0.00%> (+2.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher_intf.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher_intf.ml Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@Ngoguey42 Ngoguey42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Ship it

@clecat clecat merged commit d6e4527 into mirage:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants