Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to parser header till trailing \r\n #1082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Athishpranav2003
Copy link

This PR addresses #1032 .
Here we basically raise Exception whenever we find a incorrect section while parsing headers.

@Athishpranav2003
Copy link
Author

@rgrinberg can you please check this

@rgrinberg
Copy link
Member

Why do we need a separate exception for invalid headers? Why can't we just raise whatever we raise when we fail to parse the request for any other reason? E.g. Content-Length isn't a valid number for example.

@Athishpranav2003
Copy link
Author

@rgrinberg i cannot find the exception we raise for such issues. Could you please show which exception are you referring to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants