Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.js update #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

core.js update #18

wants to merge 2 commits into from

Conversation

brgrz
Copy link

@brgrz brgrz commented Jul 5, 2011

updated fileExtension variable to correct the regex to only return the extension when file is in format "foobar.png" (with dot as extension separator)

brgrz added 2 commits July 5, 2011 09:09
…e extension when file is in format "foobar.png" (with dot as extension separator)
@lukescott
Copy link

This is somewhat related. When you do rel="shadowbox;content=image.jpg" it incorrectly selects "iframe" as the player. Not really sure how to do diffs, but you just need to move this:

if (!obj.player)
    obj.player = S.getPlayer(obj.content);

At the end just before the return (So after the if(rel) {...}). What's happening is it's getting the player before the HTML options "trump" the JavaScript options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants