Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional spacing for routing in HOLA #65

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

skieffer
Copy link
Collaborator

@skieffer skieffer commented Aug 7, 2023

Two steps in HOLA that involve connector routing have proven in recent test cases
to sometimes lack adequate spacing between nodes, for the routing to succeed.

One step is just before the LeaflessOrthoRouter is used.

The other step is at the end, before the final routing.

* Bugfix in `isSoleDirec()` method: we were missing `ConnDirDown`.
* Clean up `route()` method:
  - Use `for`-loop instead of `while`-
  - Initialize `nullptr`
Two steps in HOLA that involve connector routing have proven in recent test cases
to sometimes lack adequate spacing between nodes, for the routing to succeed.

One step is just before the `LeaflessOrthoRouter` is used.

The other step is at the end, before the final routing.
@skieffer skieffer merged commit e196e6f into mjwybrow:master Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant