Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With Melange 3.0, OCaml 5 and styled-ppx #7

Merged
merged 5 commits into from
May 26, 2024
Merged

With Melange 3.0, OCaml 5 and styled-ppx #7

merged 5 commits into from
May 26, 2024

Conversation

ManasJayanth
Copy link
Contributor

@ManasJayanth ManasJayanth commented May 19, 2024 •
edited
Loading

Some more notes

  1. Latest server-reason-react needs ocaml 5, but dream 1.0.0-alpha4 doesn't support ocaml 5. Hence bumped dream.
  2. Pinned melange-compiler-libs doesn't support ocaml 5. Turns out we dont need it anymore.
  3. Pinned melange needs melange-compiler-libs that doesn't work with ocaml 5
  4. rescript-syntax only works with melange-dev. Not absolutely necessary for this repo
  5. Pinned reason needs <5.1.0. Hence, bumped it.
  6. Removed reactjs-jsx-ppx as it's deprecated.

@ManasJayanth ManasJayanth force-pushed the prometheansacrifice/update-dependencies branch from 219a428 to 97fec6f Compare May 25, 2024 03:14
@ManasJayanth ManasJayanth marked this pull request as ready for review May 25, 2024 03:16
@ManasJayanth
Copy link
Contributor Author

@davesnx Ready for review!

@ManasJayanth
Copy link
Contributor Author

I'll update to Melange 4 in a followup PR

@ManasJayanth
Copy link
Contributor Author

Simply upgrading to Melange 4. doesn't seem to break anything. Manual testing recommended. Page loads fine for me and works.

@ManasJayanth ManasJayanth mentioned this pull request May 25, 2024
Merged
@ManasJayanth
Copy link
Contributor Author

There seems to be "Flash of unstyled text". Is this normal, @davesnx ?

@davesnx davesnx merged commit 102fc72 into ml-in-barcelona:main May 26, 2024
1 check failed
@davesnx
Copy link
Member

davesnx commented May 26, 2024

That shouldn't happen, but can't see it. Let me merge it and see if deploy version works.

@ManasJayanth ManasJayanth deleted the prometheansacrifice/update-dependencies branch May 27, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davesnx davesnx davesnx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManasJayanth @davesnx