Fix Suspense

ml-in-barcelona · Aug 2, 2023 · 4117f59 · 4117f59
1 parent 74de672
commit 4117f59
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/react/src/react.ml b/packages/react/src/react.ml
@@ -205,8 +205,12 @@ let createContext (initial_value : 'a) : 'a context =
   { current_value = ref_value; provider; consumer }
 
 module Suspense = struct
-  let make ~fallback ~children = Suspense { fallback; children }
-end [@react.component]
+  let or_react_null = function None -> null | Some x -> x
+
+  let make ?fallback ?children () =
+    Suspense
+      { fallback = or_react_null fallback; children = or_react_null children }
+end
 
 (* let memo f : 'props * 'props -> bool = f
    let memoCustomCompareProps f _compare : 'props * 'props -> bool = f *)

diff --git a/packages/react/src/react.mli b/packages/react/src/react.mli
@@ -90,7 +90,7 @@ type 'a context = {
 val createContext : 'a -> 'a context
 
 module Suspense : sig
-  val make : fallback:element -> children:element -> element
+  val make : ?fallback:element -> ?children:element -> unit -> element
 end
 
 type any_promise = Any_promise : 'a Lwt.t -> any_promise